Libguestfs - Jan 2014 - Re: mke2fs fails due to wipefs --force

My wipefs has no --force option, as a result mke2fs command in guestfish fails.

Looks like 72dd398679cd0bb803daf306d12558369615ba70 needs an adjustment
to make use of do_wipefs?
Also str_wipefs is not used in that file.

Olaf

On Sun, Jan 19, 2014 at 07:42:58PM +0100, Olaf Hering
wrote:
> My wipefs has no --force option, as a result mke2fs command in guestfish
fails.
> 
> Looks like 72dd398679cd0bb803daf306d12558369615ba70 needs an adjustment
> to make use of do_wipefs?
> Also str_wipefs is not used in that file.
Also daemon/zero.c has a wipefs_has_force_option function.  It seems
like it would be better if this function was also used in
wipe_device_before_mkfs (in the same file).

But yes, it's definitely a bug if wipefs is causing mke2fs to fail.

How about the attached patch (only compile-tested)?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

On Sun, Jan 19, Richard W.M. Jones wrote:
> How about the attached patch (only compile-tested)?
This patch works for me. Thanks.

Olaf