Displaying 6 results from an estimated 6 matches for "wipefs_has_force_option".
2014 Jan 19
2
mke2fs fails due to wipefs --force
My wipefs has no --force option, as a result mke2fs command in guestfish fails.
Looks like 72dd398679cd0bb803daf306d12558369615ba70 needs an adjustment
to make use of do_wipefs?
Also str_wipefs is not used in that file.
Olaf
2014 Jan 19
0
Re: mke2fs fails due to wipefs --force
...M +0100, Olaf Hering wrote:
> My wipefs has no --force option, as a result mke2fs command in guestfish fails.
>
> Looks like 72dd398679cd0bb803daf306d12558369615ba70 needs an adjustment
> to make use of do_wipefs?
> Also str_wipefs is not used in that file.
Also daemon/zero.c has a wipefs_has_force_option function. It seems
like it would be better if this function was also used in
wipe_device_before_mkfs (in the same file).
But yes, it's definitely a bug if wipefs is causing mke2fs to fail.
How about the attached patch (only compile-tested)?
Rich.
--
Richard Jones, Virtualization Group, Re...
2017 Jul 27
0
[PATCH v2] daemon: Remove GUESTFSD_EXT_CMD.
...-GUESTFSD_EXT_CMD(str_wipefs, wipefs);
-
static const char zero_buf[4096];
int
@@ -81,7 +79,7 @@ do_zero (const char *device)
int
optgroup_wipefs_available (void)
{
- return prog_exists (str_wipefs);
+ return prog_exists ("wipefs");
}
/* See RHBZ#872831 */
@@ -93,7 +91,7 @@ wipefs_has_force_option (void)
CLEANUP_FREE char *out = NULL, *err = NULL;
if (flag == -1) {
- r = command (&out, &err, str_wipefs, "--help", NULL);
+ r = command (&out, &err, "wipefs", "--help", NULL);
if (r == -1) {
reply_with_error ("%s",...
2017 Jul 24
0
[PATCH 2/2] daemon: Replace GUESTFSD_EXT_CMD with --print-external-commands.
...ECLARE_EXTERNAL_COMMANDS ("wipefs")
static const char zero_buf[4096];
@@ -81,7 +81,7 @@ do_zero (const char *device)
int
optgroup_wipefs_available (void)
{
- return prog_exists (str_wipefs);
+ return prog_exists ("wipefs");
}
/* See RHBZ#872831 */
@@ -93,7 +93,7 @@ wipefs_has_force_option (void)
CLEANUP_FREE char *out = NULL, *err = NULL;
if (flag == -1) {
- r = command (&out, &err, str_wipefs, "--help", NULL);
+ r = command (&out, &err, "wipefs", "--help", NULL);
if (r == -1) {
reply_with_error ("%s",...
2017 Jul 27
3
[PATCH v2] daemon: Remove GUESTFSD_EXT_CMD.
This is a simpler patch that removes GUESTFSD_EXT_CMD completely.
2017 Jul 24
6
[PATCH 0/2] daemon: Replace GUESTFSD_EXT_CMD with --print-external-commands.
Replace GUESTFSD_EXT_CMD with a command line option
‘./guestfsd --print-external-commands’