Jim Meyering
2012-Aug-28 15:47 UTC
[Libguestfs] [PATCH hivex] maint: remove unnecessary mkdir -p
Does hivex have a trivial-patch policy?>From e23c45a2f813ac29b022faa9112c1977b651862f Mon Sep 17 00:00:00 2001From: Jim Meyering <meyering at redhat.com> Date: Tue, 28 Aug 2012 17:34:26 +0200 Subject: [PATCH hivex] maint: remove unnecessary mkdir -p * ocaml/Makefile.am (install-data-hook): Remove unneeded mkdir -p. It's job is handled by the very next mkdir -p. --- ocaml/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index eb49431..2c08be7 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -1,5 +1,5 @@ # hivex OCaml bindings -# Copyright (C) 2009-2010 Red Hat Inc. +# Copyright (C) 2009-2010, 2012 Red Hat Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -97,7 +97,6 @@ install_files += *.cmx *.cmxa endif install-data-hook: - mkdir -p $(DESTDIR)$(OCAMLLIB) mkdir -p $(DESTDIR)$(OCAMLLIB)/stublibs $(OCAMLFIND) install \ -ldconf ignore -destdir $(DESTDIR)$(OCAMLLIB) \ -- 1.7.12.116.g31e0100
Richard W.M. Jones
2012-Aug-28 16:41 UTC
[Libguestfs] [PATCH hivex] maint: remove unnecessary mkdir -p
On Tue, Aug 28, 2012 at 05:47:50PM +0200, Jim Meyering wrote:> Does hivex have a trivial-patch policy?No, but yes please push obvious trivial patches like this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
Seemingly Similar Threads
- [PATCH hivex 1/2] maint: avoid some syntax-check test failures
- "make distcheck" failure
- [PATCH 1/4] More fixes for situations where ocamlopt is not available
- [hivex] [PATCH 4/8] ocaml: Add unit test for new RLenValue type
- [PATCH] v2v: Add the test-harness used by external tests.