similar to: [PATCH hivex] maint: remove unnecessary mkdir -p

Hi Rich, I've updated hivex to use the latest from gnulib and fixed a few syntax-check failures. With these changes, almost all of "make distcheck" succeeds. (details coming separately) >From c6300c44a1eda1a55a23249fde94882ea5a1c430 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 28 Aug 2012 11:28:40 +0200 Subject: [PATCH hivex 1/2] maint:

Hi Rich, I ran these commands as non-root: ./autogen.sh && make && make distcheck It got most of the way through, but failed in the VPATH part while rebuilding from a ./_build subdir, like this: make[4]: Entering directory `/h/j/w/co/hivex/hivex-1.3.6/_build/ocaml' mkdir -p /usr/lib64/ocaml mkdir -p /usr/lib64/ocaml/stublibs ocamlfind install \

- run bindtests.opt only if available - use ocamlc -custom - Don't try to install native code if it hasn't been built (Thanks to Olaf Hering) --- mllib/Makefile.am | 2 +- ocaml/Makefile.am | 7 ++++++- ocaml/examples/Makefile.am | 11 ++++------- ocaml/run-bindtests | 2 ++ 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/mllib/Makefile.am

Signed-off-by: Alex Nelson <ajnelson at cs.ucsc.edu> --- .gitignore | 1 + ocaml/Makefile.am | 1 + ocaml/t/hivex_120_rlenvalue.ml | 43 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 ocaml/t/hivex_120_rlenvalue.ml diff --git a/.gitignore b/.gitignore index 820130e..13351e1 100644 ---

See the new man page virt-v2v-test-harness(1) added in this commit for details of this library/harness, and also how to get the external tests. --- .gitignore | 6 + Makefile.am | 3 + README | 2 + configure.ac | 8 +- po-docs/ja/Makefile.am

Signed-off-by: Alex Nelson <ajnelson at cs.ucsc.edu> --- .gitignore | 1 + ocaml/Makefile.am | 1 + ocaml/t/hivex_120_rlenvalue.ml | 42 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 44 insertions(+), 0 deletions(-) create mode 100644 ocaml/t/hivex_120_rlenvalue.ml diff --git a/.gitignore b/.gitignore index 40a4780..9c17ac6 100644 ---

This is a first attempt to build libguestfs with just a ocaml bytecode compiler. The three tools written in ocaml will be build only when an ocamlopt compiler is available. Olaf --- Makefile.am | 5 ++++- configure.ac | 2 ++ ocaml/Makefile.am | 20 +++++++++++++++++--- resize/Makefile.am | 2 +- sparsify/Makefile.am | 2 +- sysprep/Makefile.am | 2 +- 6

I've been using libguestfs-1.18.9 but decided to "upgrade" to 1.19.60. Using Ubuntu 12.04 with the older version installed via source. So I went through the same process with the new version of guestfs sources and got the following errors on 'make install': make[2]: Nothing to be done for `install-exec-am'. make install-data-hook make[3]: Entering directory

From: Jim Meyering <meyering at redhat.com> * lib/hivex.c (hivex_node_set_value): Remove unnecessary test-before-free. --- lib/hivex.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/hivex.c b/lib/hivex.c index d042f4f..a72fa77 100644 --- a/lib/hivex.c +++ b/lib/hivex.c @@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node, leave_partial:

Still don't recommend you use 'make install', but here we go. Rich.

On Thu, Jan 17, Richard W.M. Jones wrote: > On Wed, Jan 16, 2013 at 05:51:53PM +0100, Olaf Hering wrote: > > On Mon, Jan 14, Olaf Hering wrote: > > > This is a first attempt to build libguestfs with just a ocaml bytecode > > > compiler. The three tools written in ocaml will be build only when an > > > ocamlopt compiler is available. > > Here is a more

On Thu, Aug 10, 2017 at 04:49:22AM +0000, emlyn.jose@wipro.com wrote: > Hello Richard! > > Ocaml solved my problem. Thank you so much :) > > There are many unpackaged ocaml files created outside the BUILDROOT. Will removing them harm the working of the package? > > error: Installed (but unpackaged) file(s) found: > /usr/lib64/ocaml/guestfs/META >

On Thu, May 03, 2012 at 02:00:27PM +1000, Tony Breeds wrote: > Hi All, > Firstly I apologize if this is noise. I elected to not file a > bugzilla as the problem seems to be powerpc specific and with the limited > resources for Fedora developers it would seem unfair. > > I was recently trying to build a "current" libguestfs from the f16 > branch[1]. During the

Make the tests 'check_DATA' so they only get built when running the tests. This saves a couple of seconds on the build time. --- ocaml/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index e781363..a535b43 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -142,9 +142,9 @@ endif TESTS = run-bindtests

>From 34af5f3be8b04443dc151e6d070aa49cbe59b7fc Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Fri, 20 Nov 2009 11:50:54 +0100 Subject: [PATCH libguestfs] maint: remove unnecessary include of openat.h * daemon/realpath.c: Don't include "openat.h". not used. --- daemon/realpath.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff

On Fri, Dec 07, 2018 at 03:09:43PM -0600, Eric Blake wrote: > Rather than always trying to install ocaml files into $(OCAMLLIBS), > which is likely to be root-owned and therefore fail during a > './configure --prefix=$HOME/subdir', we instead choose to always > install relative to $(prefix) and let distro packagers take steps > post-install to move the distro's pre-built

This borrows from a trick in libvirt - by defining $(NULL) to expand to an empty string, we can more consistently write multi-line macros where all useful lines terminate with \, making it easier to add/remove lines without worrying about whether \ needs to be touched up on neighboring lines. --- Looks big, but is fairly mechanical. I'm also doing a similar patch for nbdkit, where it would

In OCaml 4.06 we need to link to daemon to libasmrun_pic.a (the OCaml runtime linked with -fPIC). Otherwise you will see many errors like this: /usr/bin/ld: /usr/lib64/ocaml/libasmrun.a(startup_aux.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: /usr/lib64/ocaml/libasmrun.a(startup.o): relocation

Rather than always trying to install ocaml files into $(OCAMLLIBS), which is likely to be root-owned and therefore fail during a './configure --prefix=$HOME/subdir', we instead choose to always install relative to $(prefix) and let distro packagers take steps post-install to move the distro's pre-built copy into the correct location for the distro. This fixes a 'make

On Mon, Aug 07, 2017 at 08:10:55AM -0500, Chris McIntosh wrote: > Hey Thanks Rich. > > > What distro? > Solus > > > Are the OCaml bindings for hivex actually installed? > I don't think so at this point, though make install runs this command: > > ocamlfind install \ > -ldconf ignore -destdir /home/chris/.opam/4.05.0/lib/ocaml \ > hivex \ > META