Matthew Booth
2011-Oct-17 12:09 UTC
[Libguestfs] [PATCH] inspection: Fix fstab device mapping for >26 disks
The regular expression matching disk name assumed that there was only a single letter suffix. This change handles a naming scheme for any number of disks. --- src/inspect_fs_unix.c | 51 +++++++++++++++++++++++++++++------------------- 1 files changed, 31 insertions(+), 20 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-inspection-Fix-fstab-device-mapping-for-26-disks.patch Type: text/x-patch Size: 3654 bytes Desc: not available URL: <http://listman.redhat.com/archives/libguestfs/attachments/20111017/e0725143/attachment.bin>
Richard W.M. Jones
2011-Oct-18 16:16 UTC
[Libguestfs] [PATCH] inspection: Fix fstab device mapping for >26 disks
This patch and the other 5 all look good on a first inspection. However 'git am' can't apply these patches. They seem to have been corrupted somewhere along the line. I got the two errors below: error: patch failed: src/inspect_fs_unix.c:106 error: src/inspect_fs_unix.c: patch does not apply Patch failed at 0001 inspection: Fix fstab device mapping for >26 disks error: patch failed: src/inspect_fs_unix.c:816 error: src/inspect_fs_unix.c: patch does not apply Patch failed at 0002 NFC: Remove unnecessary goto I wonder if it is better for you to fork libguestfs.git on github / your choice of git provider, then I can pull the commits. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
Apparently Analagous Threads
- [PATCH] Don't abort inspection if mdadm.conf ARRAY doesn't have a uuid
- [PATCH] inspection: Handle MD devices in fstab
- [PATCH] NFC: Cleanup iteration over fstab entries in inspect_fs_unix.c
- [PATCH 0/4] Deprecate and remove use of the Perl inspection API
- [PATCH 0/5] Small inspection improvements