similar to: [PATCH] inspection: Fix fstab device mapping for >26 disks

--- src/inspect_fs_unix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/inspect_fs_unix.c b/src/inspect_fs_unix.c index 1ef4ca4..5695adc 100644 --- a/src/inspect_fs_unix.c +++ b/src/inspect_fs_unix.c @@ -1113,7 +1113,7 @@ map_md_devices(guestfs_h *g, Hash_table **map) free(uuid_path); if (!uuid) { free(dev); - goto error; + continue; }

This patch fixes inspection when fstab contains devices md devices specified as /dev/mdN. The appliance creates these devices without reference to the guest's mdadm.conf so, for e.g. /dev/md0 in the guest will often be created as /dev/md127 in the appliance. With this patch, we match the uuids of detected md devices against uuids specified in mdadm.conf, and map them appropriately when we

Select non-comment labels using an augeas path to return the correct nodes in the first instance, rather than applying a regular expression to all results. Iterate over returned matches using a char** iterator. Use asprintf() to ensure the path string buffer is the correct size. --- src/inspect_fs_unix.c | 50 +++++++++++++++++++++--------------------------- 1 files changed, 22 insertions(+),

This is a fix for: https://bugzilla.redhat.com/show_bug.cgi?id=642930 These patches remove all use of the Perl inspection API (although leaving the code, since it is used by virt-v2v). The tools have been modified so they use the core inspection API. Virt inspector has been basically rewritten to remove excess cruft and to only use the core API (see the final commit for more details). Rich.

Few improvements to the results of the inspection on some distros. Pino Toscano (5): inspect: factorize list of rolling distros inspect: detect Gentoo from os-release inspect: fully detect Arch Linux from os-release inspect: return osinfo short IDs for rolling distros inspect: correct osinfo ID for ALT Linux >= 8 daemon/inspect_fs_unix.ml | 15 +++++++++------

Thanks: Qingzheng Zhang --- daemon/inspect_fs.ml | 7 +++++++ daemon/inspect_fs_unix.ml | 16 +++++++++++++++- daemon/inspect_types.ml | 2 ++ daemon/inspect_types.mli | 1 + generator/actions_inspection.ml | 4 ++++ inspector/virt-inspector.rng | 1 + 6 files changed, 30 insertions(+), 1 deletion(-) diff --git a/daemon/inspect_fs.ml b/daemon/inspect_fs.ml

This short patch series fixes various problems with the Java bindings, including enabling support for functions that return hash tables (returned as Map<String,String>). With this, the Java bindings are improved although still not perfect. The last remaining issue is to implement support for functions that take optional arguments. Rich. -- Richard Jones, Virtualization Group, Red Hat

This patch series implements user cancellation. What this means is that the "user" (or any library caller) can cancel certain long-running operations. Currently it is only possible to cancel upload and download operations (ie. anything in the generator which uses FileIn and FileOut). The mechanism in the protocol to implement cancellation already exists, and it is already used to

I have a 15G qcow2 xp vm with only 1 partition: -rw-------. 1 root root 10514137088 Sep 12 11:10 XP.img I want to resize it to 20G. So I : virsh vol-create-as --format raw windows XP-new-20G.img 20G Vol XP-new-20G.img created -rw-------. 1 root root 21474836480 Sep 12 13:17 XP-new-20G.img But: virt-resize --expand /dev/sda1 XP.img XP-new-20G.img Summary of changes: /dev/sda1: partition will

I'm trying to use guestmount to install some kernel modules in a guest: [mbooth at mbooth linux-2.6 (amit)]$ make modules_install INSTALL_MOD_PATH=~/etch ln: creating symbolic link `/home/mbooth/etch/lib/modules/2.6.32-rc6/source': No such file or directory make: *** [_modinst_] Error 1 I think something's screwy with symlinks. In the following, /tmp/source is a symlink, and I

From: Michael Scherer <misc at zarb.org> Without this, configure will always enable erlang, no matter what argument are passed. Now, we can disable it, even if configure still need the erlang compiler for some obscure reason. --- configure.ac | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 337a3ed..e0bed2f 100644 ---

The more I look at this patch, the less I like it. I would summarise why I think it's wrong here, but it's better if you look at the message I posted on the gnulib mailing list here first: http://lists.gnu.org/archive/html/bug-gnulib/2009-11/msg00434.html Directly accessing errno on Windows is wrong: you won't see the true reasons for an error by doing that. However depending on

Followup of commit 70407cd622dda6f088a0876e1e1ae669e9f8a281 for openSUSE Thumbleweed. --- daemon/inspect_fs_unix.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/inspect_fs_unix.ml b/daemon/inspect_fs_unix.ml index 4dd89fa8f..925db06a3 100644 --- a/daemon/inspect_fs_unix.ml +++ b/daemon/inspect_fs_unix.ml @@ -143,7 +143,7 @@ and distro_of_os_release_id = function |

Even though the list of checks is very short, at least this migrates from imperative checks to a "declarative" one. There should be no behaviour change, other than using os-release if it contains all the needed information. --- daemon/inspect_fs_unix.ml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/daemon/inspect_fs_unix.ml

The current guestfs_find API call contains an undocumented limit: It needs to marshall the whole list of filenames into a single protocol message. Unfortunately just about any Linux guest breaks this limit if you try 'guestfs_find ("/")' so this isn't much use. These patches add a new API call (find0) which breaks this limit by using a FileOut parameter. It's slightly

These two patches implement the first (and hardest) part of the fix for CVE-2010-3851. This adds a way to specify the format when adding a drive, avoiding qemu's auto-detection. In order to avoid an explosion of different add_drive_* functions (we have 4 already), we have implemented a way to specify optional arguments to functions, so all we need is a single new 'add_drive_opts'

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

NOT a problem, just a question about distro checking: the default value is REDHAT, then you check debian (or ubuntu) and then archlinux why are you using two if statements ? -- Evaggelos Balaskas - Unix System Engineer http://gr.linkedin.com/in/evaggelosbalaskas

This series fixes inspection in the case that fstab contains references to md devices. I've made a few changes since the previous posting, which I've summarised below. [PATCH 1/8] build: Create an MD variant of the dummy Fedora image I've double checked that no timestamp is required in the Makefile. The script will not run a second time to build fedora-md2.img. [PATCH 2/8] build:

These patches are a distillation of the good patches from the previous large / for-discussion-only error handling patch. See: https://www.redhat.com/archives/libguestfs/2009-November/msg00298.html Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine.