Jim Meyering
2009-Aug-18 08:16 UTC
[Libguestfs] [PATCH libguestfs] avoid compiler warnings about unused vars in generated code
Very similar to the one for protocol.c...>From b5896dfb673a6f8dfd536ae86a6ea3d2925d2af5 Mon Sep 17 00:00:00 2001From: Jim Meyering <meyering at redhat.com> Date: Tue, 18 Aug 2009 10:15:57 +0200 Subject: [PATCH libguestfs] avoid compiler warnings about unused vars in generated code * fish/Makefile.am: Compile rc_protocol.c into a convenience library, so it can have its own CFLAGS, and link that into guestfish. generator.ml: Use TABs, not spaces for indentation. --- fish/Makefile.am | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/fish/Makefile.am b/fish/Makefile.am index 8c289dc..5bf3fbd 100644 --- a/fish/Makefile.am +++ b/fish/Makefile.am @@ -35,12 +35,15 @@ guestfish_SOURCES = \ lcd.c \ more.c \ rc.c \ - rc_protocol.c \ - rc_protocol.h \ reopen.c \ tilde.c \ time.c +# This convenience library is solely to avoid compiler warnings +# in its generated sources. +librc_protocol_la_SOURCES = rc_protocol.c +librc_protocol_la_CFLAGS = -Wall -Wno-unused + BUILT_SOURCES = \ rc_protocol.c \ rc_protocol.h @@ -50,8 +53,13 @@ guestfish_CFLAGS = \ -I$(top_srcdir)/fish -I$(top_builddir)/fish \ -Wall \ -DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"' + guestfish_LDADD = $(top_builddir)/src/libguestfs.la $(LIBREADLINE) +# Make libguestfs use the convenience library. +noinst_LTLIBRARIES = librc_protocol.la +guestfish_LDADD += librc_protocol.la + if HAVE_RPCGEN rc_protocol.c: rc_protocol.x rm -f $@-t $@-t2 -- 1.6.4.378.g88f2f
Richard W.M. Jones
2009-Aug-18 08:18 UTC
[Libguestfs] [PATCH libguestfs] avoid compiler warnings about unused vars in generated code
On Tue, Aug 18, 2009 at 10:16:51AM +0200, Jim Meyering wrote:> Very similar to the one for protocol.c...ACK. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
Maybe Matching Threads
- [PATCH] lib: Prefer tirpc for XDR, and rationlise how we search for alternatives.
- [PATCH] build: Reference RPC_CFLAGS where needed
- [PATCH] Fix dependencies on generator.ml
- [PATCH 3/3] tools: build common fish sources in a static library
- two more warning-avoidance patches