similar to: [PATCH libguestfs] avoid compiler warnings about unused vars in generated code

glibc in Fedora is currently configured with `--enable-obsolete-rpc', so I guess we can see the way the wind is blowing. (1) This changes our configure script to prefer libtirpc if it is available. If libtirpc is _not_ available then: (a) Headers must be located in <rpc/xdr.h>, or the user must supply the right CFLAGS. (b) XDR functions must be located in one of -lportablexdr, -lrpc,

Since glibc-2.26 removed the /usr/include/rpc/rpc.h, it caused problem even though probing for libtirpc has taken place and worked properly. The problem is that RPC_CFLAGS (usually `-I/usr/include/tirpc` on Linux) was not used in places where it was needed. So the build failed with messages like the following: In file included from guestfs_protocol.c:6:0: guestfs_protocol.h:9:10: fatal error:

This change adds an explicit dependency on generator.ml for every file it generates, except java files. Java is left for another time because it's considerably trickier. This fixes parallel make, and will automatically re-create generated files when make is run from any directory. It also fixes the problem which efad4f53 was targetting. Specifically, src/guestfs_protocol.(c|h) had an

Create a new libfishcommon convenience static library to build just once (instead of 12 times!) the majority of the guestfish sources used in the rest of the C tools (mostly for command line stuff, inspection, and mount). The notable exceptions not using libfishcommon are guestfish itself, and virt-rescue: both need to build at least one of the common sources using additional CPPFLAGS. ---

>From 9e99a1c6cb655a56d7f09dabd10a77a3802bf96d Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 17 Aug 2009 18:44:37 +0200 Subject: [PATCH libguestfs 1/2] avoid compiler warnings about unused vars in generated code * src/Makefile.am: Compile protocol.c into a convenience library, so it can have its own CFLAGS, and link that with the destination one. ---

--- fish/Makefile.am | 2 +- src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fish/Makefile.am b/fish/Makefile.am index 6ca8a82..16a29b0 100644 --- a/fish/Makefile.am +++ b/fish/Makefile.am @@ -139,7 +139,7 @@ if HAVE_RPCGEN rc_protocol.c: rc_protocol.x rm -f $@-t $@-t2 $(RPCGEN) -c -o $@-t $< - sed 's,\.\./\.\./fish/,,' < $@-t >

v1 -> v2: - No functional changes to the patch, just fixes a few bugs. Rich.

On Mon, Jul 06, 2020 at 07:52:42PM -0300, Ezequiel Santos wrote: > Actually, I was trying to compile it from the AUR repository ( > https://aur.archlinux.org/packages/libguestfs-git/) when I came across this > problem. > Now, answering your question: > *1. Are there any files under common/ ?* > Yes. There are several files there in, including Makefile.am, > guestfs_protocol.x,

This new series condenses all of the previously posted patches into new patch 1/2. The second patch is a new fix for parallel build in the haskell directory.

Here is a bunch of small patches to make fish/ build with most warnings enabled: [1/9] edit.c: avoid warning about signed/unsigned comparison [2/9] fish.c: avoid warnings [3/9] tilde.c: avoid a warning [4/9] fish.c: avoid "assignment discards qualifiers..." warning [5/9] fish.c: avoid signed/unsigned-comparison warning [6/9] fish.c: don't perform arithmetic on void*

Nearly any program that writes to standard output can benefit from this sort of fix. Without it, running e.g., ./guestfish --version > /dev/full would exit successfully, even though it got ENOSPC when writing to the full device. That means regular output redirected to a file on a full partition may also fail to be written, and the error ignored. Before: $ guestfish --version >

Patch 1/5 is a repost. Only change is title update. These fix parallel make on my machine, and additionally make building from subdirectories more correct.

There were a few "infelicities" that kept the "make distcheck" test from passing. These three patches combine to fix all of them, punting on only one by disabling the install-data-hook rule. >From 7504acedcb71bd80d99abe412e6669b267cade38 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Fri, 21 Aug 2009 13:37:18 +0200 Subject: [PATCH 1/3]

When I build with LC_ALL=C in my environment, the all-local rule generates po/POTFILES.in that is sorted differently from the on that is checked in: diff --git a/po/POTFILES.in b/po/POTFILES.in index ca01b3d..154915a 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -63,12 +63,11 @@ fish/tilde.c fish/time.c inspector/virt-inspector.pl

On principle, we shouldn't ignore write failure: >From 56317a61bc22e935dc750cf669a164bacc12cf12 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Thu, 20 Aug 2009 12:29:46 +0200 Subject: [PATCH libguestfs] daemon: diagnose socket write failure * daemon/proto.c (send_chunk): Don't ignore socket-write error. --- daemon/proto.c | 8 +++++--- 1 files

Hi Matt, You need to "git add" Makefile.PL.in to the repo. Once you do that, and apply the following patch, most of "make distcheck" will work. The only remaining failure seems to be that these files are not removed by "make uninstall": ERROR: files left after uninstall: ./lib64/perl5/5.10.0/x86_64-linux-thread-multi/perllocal.pod

One final set: cmds.c:968:13: warning: 'print_lvm_pv' defined but not used cmds.c:1012:13: warning: 'print_lvm_vg' defined but not used cmds.c:1055:13: warning: 'print_lvm_lv' defined but not used cmds.c:1142:13: warning: 'print_dirent' defined but not used cmds.c:1196:13: warning: 'print_xattr' defined but not used cmds.c:1220:13:

I see the following warnings: cmds.c:934:13: warning: 'print_int_bool_list' defined but not used cmds.c:1093:13: warning: 'print_stat_list' defined but not used cmds.c:1124:13: warning: 'print_statvfs_list' defined but not used cmds.c:1171:13: warning: 'print_version_list' defined but not used This patch makes it so we don't emit the unused

I got this build failure: Guestfs.hs:1941:11: parse error on input `module' where that (generated) file looked like this: 1940 modprobe :: GuestfsH -> String -> IO () 1941 modprobe h module = do 1942 r <- withCString module $ \module -> withForeignPtr h (\p -> c_modprobe p module) 1943 if (r == -1) 1944 then do 1945 err <-

Look for libint/gettext and link to it; this properly detects whether libint is part of libc. --- align/Makefile.am | 1 + builder/Makefile.am | 2 ++ cat/Makefile.am | 4 ++++ configure.ac | 3 +++ customize/Makefile.am | 2 +- df/Makefile.am | 1 + diff/Makefile.am | 1 + edit/Makefile.am | 1 + erlang/Makefile.am