search for: rc_protocol

...for protocol.c... >From b5896dfb673a6f8dfd536ae86a6ea3d2925d2af5 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 18 Aug 2009 10:15:57 +0200 Subject: [PATCH libguestfs] avoid compiler warnings about unused vars in generated code * fish/Makefile.am: Compile rc_protocol.c into a convenience library, so it can have its own CFLAGS, and link that into guestfish. generator.ml: Use TABs, not spaces for indentation. --- fish/Makefile.am | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/fish/Makefile.am b/fish/Makefile.am index 8c289d...

...c8ba3ea..8e3b9eb 100644 --- a/fish/Makefile.am +++ b/fish/Makefile.am @@ -17,15 +17,27 @@ bin_PROGRAMS = guestfish +GENERATOR_ML = \ + cmds.c \ + completion.c + +.PHONY: force + +$(GENERATOR_ML): force + $(MAKE) -C $(top_builddir)/src stamp-generator + +BUILT_SOURCES = \ + $(GENERATOR_ML) \ + rc_protocol.h \ + rc_protocol.c + EXTRA_DIST = \ + $(BUILT_SOURCES) \ rc_protocol.x -CLEANFILES = rc_protocol.c rc_protocol.h - guestfish_SOURCES = \ + $(GENERATOR_ML) \ alloc.c \ - cmds.c \ - completion.c \ destpaths.c \ echo.c \ edit.c \ @@ -44,10 +56,6 @@ guestfish_SOURCES = \ librc_protocol_...

I am a Manjaro user and was compiling libguestfs today from the AUR (it doesn't reside on Arch/Manjaro repos) and got the following error: "make[2]: Leaving directory '/home/matador/AUR/libguestfs-git/src/libguestfs/common/errnostring' Making all in common/protocol make[2]: Entering directory '/home/matador/AUR/libguestfs-git/src/libguestfs/common/protocol' make[2]: ***

...; > > > $ grep -n rpcgen makepkg.out > > 3426:checking for rpcgen... rpcgen > > 4712:checking for rpcgen... rpcgen > > 5409:rpcgen -c -o guestfs_protocol.c-t guestfs_protocol.x > > 5410:rpcgen -h -o guestfs_protocol.h-t guestfs_protocol.x > > 5749:rpcgen -h -o rc_protocol.h-t rc_protocol.x > > 5750:rpcgen -c -o rc_protocol.c-t rc_protocol.x > > > > So I think the solution would be to add *rpcsvc-proto* (provider of > > rpcgen) to makedepends. On feedback that it works I'll make this update. > > > > I installed *rpcsvc-proto...

--- fish/Makefile.am | 2 +- src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fish/Makefile.am b/fish/Makefile.am index 6ca8a82..16a29b0 100644 --- a/fish/Makefile.am +++ b/fish/Makefile.am @@ -139,7 +139,7 @@ if HAVE_RPCGEN rc_protocol.c: rc_protocol.x rm -f $@-t $@-t2 $(RPCGEN) -c -o $@-t $< - sed 's,\.\./\.\./fish/,,' < $@-t > $@-t2 + sed 's,\.\./\(\.\./\)*fish,.,' < $@-t > $@-t2 rm $@-t mv $@-t2 $@ diff --git a/src/Makefile.am b/src/Makefile.am index 82a4004..28a1b92 100644 --- a/src/Ma...

This new series condenses all of the previously posted patches into new patch 1/2. The second patch is a new fix for parallel build in the haskell directory.

..._CFLAGS) $(WERROR_CFLAGS) \ + $(RPC_CFLAGS) \ $(LIBCONFIG_CFLAGS) \ $(LIBXML2_CFLAGS) @@ -147,32 +148,23 @@ guestfish_LDADD = \ $(LIBREADLINE) \ $(LIBTINFO_LIBS) \ $(LTLIBINTL) \ + $(RPC_LIBS) \ -lm # Make guestfish use the convenience libraries. noinst_LTLIBRARIES = libcmds.la librc_protocol.la guestfish_LDADD += libcmds.la librc_protocol.la ../gnulib/lib/libgnu.la -if HAVE_RPCGEN -RPCGEN_DEFS = -if HAVE_XDR_U_INT64_T -RPCGEN_DEFS += -DHAVE_XDR_U_INT64_T=1 -else -if HAVE_XDR_UINT64_T -RPCGEN_DEFS += -DHAVE_XDR_UINT64_T=1 -endif -endif - rc_protocol.c: rc_protocol.x rm -f $@-t $@-...

Patch 1/5 is a repost. Only change is title update. These fix parallel make on my machine, and additionally make building from subdirectories more correct.

v1 -> v2: - No functional changes to the patch, just fixes a few bugs. Rich.

...LAGS) if HAVE_RPCGEN diff --git a/fish/Makefile.am b/fish/Makefile.am index a6efbb43966c..8623e8ecae72 100644 --- a/fish/Makefile.am +++ b/fish/Makefile.am @@ -101,7 +101,7 @@ guestfish_SOURCES = \ # This convenience library is solely to compile its generated sources with # custom flags. librc_protocol_la_SOURCES = rc_protocol.c rc_protocol.h -librc_protocol_la_CFLAGS = -Wall -Wno-unused -fno-strict-aliasing +librc_protocol_la_CFLAGS = -Wall -Wno-unused -fno-strict-aliasing $(RPC_CFLAGS) # Build the command lookup perfect hash code. The generated code has # lots of warnings so we must compil...

Without this option, configure will fail when there is no display. Signed-off-by: Masami HIRATA <msmhrt at gmail.com> --- configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index de8a064..61d6f69 100644 --- a/configure.ac +++ b/configure.ac @@ -593,16 +593,16 @@ working. AC_MSG_FAILURE([$QEMU version must be >=

...ES.in | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index f118291..3cba8bc 100644 --- a/Makefile.am +++ b/Makefile.am @@ -165,7 +165,7 @@ all-local: grep -v 'examples/' | \ grep -v '/guestfs_protocol.c' | \ grep -v '/rc_protocol.c' | \ - sort | \ + LC_ALL=C sort | \ sed 's,^\./,,' > po/POTFILES.in # Pkgconfig. diff --git a/po/POTFILES.in b/po/POTFILES.in index ca01b3d..154915a 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -63,12 +63,11 @@ fish/tilde.c fish/time.c inspector/virt-inspector.pl java...

Nearly any program that writes to standard output can benefit from this sort of fix. Without it, running e.g., ./guestfish --version > /dev/full would exit successfully, even though it got ENOSPC when writing to the full device. That means regular output redirected to a file on a full partition may also fail to be written, and the error ignored. Before: $ guestfish --version >

....am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index a4f4b0b..87efb2d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -194,6 +194,7 @@ all-local: grep -v '^perl/examples/' | \ grep -v '/guestfs_protocol.c' | \ grep -v '/rc_protocol.c' | \ + grep -v 'appliance/debian/root' | \ LC_ALL=C sort | \ sed 's,^\./,,' > po/POTFILES.in -- 1.6.5.2 -------------- next part -------------- >From a3be3a3b877277c1e4b130e1676b9ad307cafa10 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at debian5x64.ho...

>From 9e99a1c6cb655a56d7f09dabd10a77a3802bf96d Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 17 Aug 2009 18:44:37 +0200 Subject: [PATCH libguestfs 1/2] avoid compiler warnings about unused vars in generated code * src/Makefile.am: Compile protocol.c into a convenience library, so it can have its own CFLAGS, and link that with the destination one. ---

Here is a bunch of small patches to make fish/ build with most warnings enabled: [1/9] edit.c: avoid warning about signed/unsigned comparison [2/9] fish.c: avoid warnings [3/9] tilde.c: avoid a warning [4/9] fish.c: avoid "assignment discards qualifiers..." warning [5/9] fish.c: avoid signed/unsigned-comparison warning [6/9] fish.c: don't perform arithmetic on void*

Hi, from time to time, there have been requests (or attempts, like the mingw port posted on the list some months ago) to make libguestfs work on OSes different than Linux. Of course this would imply using a fixed appliance, since it is currently heavily dependent on Linux. The attached series provides some easy changes in this direction, resolving some of the easy issues found in porting to

...ir-rules.mk ACLOCAL_AMFLAGS = -I m4 # Basic source for the library. -SUBDIRS = gnulib/lib images src examples po +SUBDIRS = gnulib/lib images src examples po po-docs if ENABLE_DAEMON SUBDIRS += daemon @@ -181,6 +181,7 @@ all-local: grep -v '/guestfs_protocol.c' | \ grep -v '/rc_protocol.c' | \ grep -v 'appliance/debian/root' | \ + grep -v '^po-docs/' | \ LC_ALL=C sort | \ sed 's,^\./,,' > po/POTFILES.in diff --git a/README b/README index 2b8fdac..199f595 100644 --- a/README +++ b/README @@ -94,6 +94,8 @@ in virt-inspector). - (Optional, bu...

By splitting up large C files we can make parallel compiles a bit faster. Rich.

This series fixes inspection in the case that fstab contains references to md devices. I've made a few changes since the previous posting, which I've summarised below. [PATCH 1/8] build: Create an MD variant of the dummy Fedora image I've double checked that no timestamp is required in the Makefile. The script will not run a second time to build fedora-md2.img. [PATCH 2/8] build: