Icecast - Oct 2006 - Metadata in non UTF-8 encoding support (patch)

Hi there.

http://defan.zenon.net/freebsd/patch-icecast2-encoding

This patch allows icecast to encode metadata from
specified charset to UTF-8 for stats output and
using different charset for log output.

Variables to add to config (for example):

<icecast>
  <metadataenc>CP1251</metadataenc>
  ...
  <logging>
     ...
     <logenc>KOI8-R</logenc>
     ...
  </logging>
</icecast>

libiconv is used to do conversion task.
It works for me on freebsd 6-stable and icecast 2.3.1.

--
Andrew N. Below
Zenon N.S.P.

On 10/23/06, Andrew N. Below <defan@zenon.net>
wrote:
> Hi there.
>
> http://defan.zenon.net/freebsd/patch-icecast2-encoding
>
> This patch allows icecast to encode metadata from
> specified charset to UTF-8 for stats output and
> using different charset for log output.
This sounds somewhat like the wrong approach to me.

The metadata should be transformed to UTF-8 on input, so it's stored
internally to icecast ONLY as UTF-8. This would be better done as a
mountpoint-specific option, as it's not something that I'd expect to
be the same across all mountpoints.

Using a different charset for logging sounds... strange. Why not just
always log in UTF-8, consistently?

That said, some solution for this problem would be nice.

Mike

i'd be happy with any solution.

XML listings of streams often have parse errors due to non UTF-8 
characters in the metadata.
(My own quick and dirty fix was for XSL to generate plain-text output..)

--mark

On Mon, 23 Oct 2006 17:34:36 +0200, Michael Smith wrote:
> On 10/23/06, Andrew N. Below <defan@zenon.net> wrote:
> >Hi there.
> >
> >http://defan.zenon.net/freebsd/patch-icecast2-encoding
> >
> >This patch allows icecast to encode metadata from
> >specified charset to UTF-8 for stats output and
> >using different charset for log output.
> 
> This sounds somewhat like the wrong approach to me.
> 
> The metadata should be transformed to UTF-8 on input, so it's stored
> internally to icecast ONLY as UTF-8. This would be better done as a
> mountpoint-specific option, as it's not something that I'd expect
to
> be the same across all mountpoints.
> 
> Using a different charset for logging sounds... strange. Why not just
> always log in UTF-8, consistently?
> 
> That said, some solution for this problem would be nice.
> 
> Mike
> _______________________________________________
> Icecast mailing list
> Icecast@xiph.org
> http://lists.xiph.org/mailman/listinfo/icecast