Icecast dev - Sep 2008 - [libshout] Add mime/content-type parameter

Le Monday 22 September 2008 18:48:34 Ivo Emanuel Gon?alves, vous avez
?crit?:
> On 9/22/08, Romain Beauxis <toots at rastageeks.org> wrote:
> > I don't get where the patch should be changed ? The default mime
value
> > for ogg streams ?
>
> Yep. ?Any of the three media types should be allowed. ?There is simply
> no "default mime" anymore.
>
> application/ogg is now for applications and (very) complex multimedia.
> video/ogg is for video and audio, say films.
> audio/ogg is for anything audio, be it Vorbis, Speex, FLAC, whatever.
>
> If libshout can only do audio (I thought it could do video too, but
> apparently I'm wrong)
I believe it can.
> the default should be audio/ogg, with 
> application/ogg available as a legacy option for a couple of years
> until all software updates to use audio/ogg exclusively.
Humm..
So default mime would remain "application/ogg", but
"audio/ogg"
and "video/ogg" should be documented, right ?

It is also be possible to add new formats, which would be:
 * SHOUT_FORMAT_OGG_AUDIO
 * SHOUT_FORMAT_OGG_VIDEO
with the corresponding default mimes...

(I don't like this since the formats no longer have the same semantics)

This could 

Romain

Le Monday 22 September 2008 19:04:48 Romain Beauxis, vous avez
?crit?:
> Humm..
> So default mime would remain "application/ogg", but
"audio/ogg"
> and "video/ogg" should be documented, right ?
>
> It is also be possible to add new formats, which would be:
> ?* SHOUT_FORMAT_OGG_AUDIO
> ?* SHOUT_FORMAT_OGG_VIDEO
> with the corresponding default mimes...
>
> (I don't like this since the formats no longer have the same semantics)
Ok, please find attached the two possibilities.

First patch is 100% backward compatible, and only documents the new audio/ogg 
and video/ogg mime types.

Second patch is not backward compatible and sets "audio/ogg" if you
used the
deprecated SHOUT_FORMAT_VORBIS. 
Furthermore, it adds new shout formats for ogg sub-types, namely
 * SHOUT_FORMAT_OGG_AUDIO
 * SHOUT_FORMAT_OGG_VIDEO

Mime types are set accordingly for these formats, and SHOUT_FORMAT_VORBIS is 
then alised to SHOUT_FORMAT_OGG_AUDIO.

What do you think, may one of them qualify for an inclusion ?


Romain
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shout_mime_param_backward.patch
Type: text/x-diff
Size: 3980 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/icecast-dev/attachments/20080924/ab052477/attachment.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shout_mime_param_newtypes.patch
Type: text/x-diff
Size: 5544 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/icecast-dev/attachments/20080924/ab052477/attachment-0001.patch

On 9/24/08, Romain Beauxis <toots at rastageeks.org>
wrote:
> First patch is 100% backward compatible, and only documents the new
> audio/ogg and video/ogg mime types.
"Documents" doesn't sound good.  A quick look at the patch seems
to
imply that libshout doesn't act on those two.
> Second patch is not backward compatible and sets "audio/ogg" if
you used the
> deprecated SHOUT_FORMAT_VORBIS.
> Furthermore, it adds new shout formats for ogg sub-types, namely
>  * SHOUT_FORMAT_OGG_AUDIO
>  * SHOUT_FORMAT_OGG_VIDEO
>
> Mime types are set accordingly for these formats, and SHOUT_FORMAT_VORBIS
is
> then alised to SHOUT_FORMAT_OGG_AUDIO.
This sounds like a better approach.  When you say it's not
backward-compatible, do you reckon something would break?

I hope libshout doesn't require rewriting some parts.

-Ivo