Icecast dev - Sep 2008 - [libshout] Add mime/content-type parameter

On 9/24/08, Romain Beauxis <toots at rastageeks.org>
wrote:
> First patch is 100% backward compatible, and only documents the new
> audio/ogg and video/ogg mime types.
"Documents" doesn't sound good.  A quick look at the patch seems
to
imply that libshout doesn't act on those two.
> Second patch is not backward compatible and sets "audio/ogg" if
you used the
> deprecated SHOUT_FORMAT_VORBIS.
> Furthermore, it adds new shout formats for ogg sub-types, namely
>  * SHOUT_FORMAT_OGG_AUDIO
>  * SHOUT_FORMAT_OGG_VIDEO
>
> Mime types are set accordingly for these formats, and SHOUT_FORMAT_VORBIS
is
> then alised to SHOUT_FORMAT_OGG_AUDIO.
This sounds like a better approach.  When you say it's not
backward-compatible, do you reckon something would break?

I hope libshout doesn't require rewriting some parts.

-Ivo

Le Thursday 25 September 2008 23:00:20 Ivo Emanuel Gon?alves, vous avez 
?crit?:
> > Mime types are set accordingly for these formats, and
SHOUT_FORMAT_VORBIS
> > is then alised to SHOUT_FORMAT_OGG_AUDIO.
>
> This sounds like a better approach. ?When you say it's not
> backward-compatible, do you reckon something would break?
>
> I hope libshout doesn't require rewriting some parts.
No, the API is 100% backward compatible. Only difference is that programs that 
use the (deprecated) SHOUT_FORMAT_VORBIS will then send the
"audio/ogg" mime
type instead of "application/ogg". I don't believe this will cause
any
trouble.


Romain

On 9/25/08, Romain Beauxis <toots at rastageeks.org>
wrote:
> No, the API is 100% backward compatible. Only difference is that programs
> that use the (deprecated) SHOUT_FORMAT_VORBIS will then send the
> "audio/ogg" mime type instead of "application/ogg". I
don't believe this will
> cause any trouble.
I'm sold.  If nobody sees a reason to oppose I'll be applying the
patch*.

-Ivo

* as soon as I have some time.  New job's killing me.