freebsd stable - Jul 2012 - buildworld fails with clang

Hello,

9-STABLE fails to build with clang and *without* "NO_WERROR=" and
"WERROR=" in /etc/make.conf. It used to work not long before :
FreeBSD zozo.afpicl.lan 9.0-STABLE FreeBSD 9.0-STABLE #0 r237222M: Mon
Jun 18 10:18:54 CEST 2012
root@zozo.afpicl.lan:/usr/obj/usr/src/sys/CORE  amd64

# svnversion
238067M
# make NOCLEAN=yes NO_CLEAN=yes buildworld
[...]
===> cddl/lib (obj,depend,all,install)
===> cddl/lib/drti (obj)
===> cddl/lib/libavl (obj)
===> cddl/lib/libctf (obj)
===> cddl/lib/libdtrace (obj)
===> cddl/lib/libnvpair (obj)
===> cddl/lib/libumem (obj)
===> cddl/lib/libuutil (obj)
===> cddl/lib/libzfs (obj)
===> cddl/lib/libzpool (obj)
===> cddl/lib/drti (depend)
===> cddl/lib/libavl (depend)
===> cddl/lib/libctf (depend)
===> cddl/lib/libdtrace (depend)
===> cddl/lib/libnvpair (depend)
===> cddl/lib/libumem (depend)
===> cddl/lib/libuutil (depend)
===> cddl/lib/libzfs (depend)
===> cddl/lib/libzpool (depend)
===> cddl/lib/drti (all)
===> cddl/lib/libavl (all)
===> cddl/lib/libctf (all)
===> cddl/lib/libdtrace (all)
clang  -O2 -pipe -march=corei7 -fomit-frame-pointer
-I/usr/obj/usr/src/cddl/lib/libdtrace -I/usr/src/cddl/lib/libdtrace
-I/usr/src/cddl/lib/libdtrace/../../../sys/cddl/dev/dtrace/amd64
-I/usr/src/cddl/lib/libdtrace/../../../sys/cddl/compat/opensolaris
-I/usr/src/cddl/lib/libdtrace/../../../cddl/compat/opensolaris/include
 -I/usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/head
-I/usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libctf/common
 -I/usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace/common
 -I/usr/src/cddl/lib/libdtrace/../../../sys/cddl/contrib/opensolaris/uts/common
-I/usr/src/cddl/lib/libdtrace/../../../sys/cddl/contrib/opensolaris/uts/intel
-DDIS_MEM -DNEED_SOLARIS_BOOLEAN -std=gnu89 -Qunused-arguments
-fstack-protector -Wsystem-headers -Werror -Wno-pointer-sign
-Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare
-Wno-unused-value -Wno-parentheses-equality -Wno-unused-function
-Wno-conversion -Wno-switch -Wno-switch-enum -Wno-parentheses
-Wno-unknown-pragmas -c
/usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c
-o dt_consume.o
/usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c:799:40:
error: format specifies type 'long long' but the
      argument has type 'int64_t' (aka 'long')
[-Werror,-Wformat]
        (void) snprintf(c, sizeof (c), ">= %lld", value);
                                           ~~~^   ~~~~~
                                           %ld
1 error generated.
*** [dt_consume.o] Error code 1

Stop in /usr/src/cddl/lib/libdtrace.
*** [all] Error code 1

I used NOCLEAN and NO_CLEAN to see the error because I was compiling
with -j8 before, but yes, my /usr/obj/ was clean at the time I
attempted to buildworld.

This may be the culprit ?

# svn log -l 1 /usr/src/cddl/contrib/opensolaris/lib/libdtrace/
------------------------------------------------------------------------
r237870 | pfg | 2012-07-01 06:15:14 +0200 (dim 01 jul 2012) | 8 lignes

MFC     r237624, r237714, r237716, r237860:

Bring llquantize support into Dtrace.

Bryan Cantrill implemented the equivalent of semi-log graph
paper for Dtrace so llquantize will use one logarithmic and
one linear scale.

-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."

On 2012-07-03 14:23, Olivier Smedts wrote:
> 9-STABLE fails to build with clang and *without* "NO_WERROR=" and
> "WERROR=" in /etc/make.conf. It used to work not long before :
...
>
/usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c:799:40:
> error: format specifies type 'long long' but the
>       argument has type 'int64_t' (aka 'long')
[-Werror,-Wformat]
>         (void) snprintf(c, sizeof (c), ">= %lld", value);
>                                            ~~~^   ~~~~~
>                                            %ld
...
> This may be the culprit ?
> 
> # svn log -l 1 /usr/src/cddl/contrib/opensolaris/lib/libdtrace/
> ------------------------------------------------------------------------
> r237870 | pfg | 2012-07-01 06:15:14 +0200 (dim 01 jul 2012) | 8 lignes
> 
> MFC     r237624, r237714, r237716, r237860:
Yep, that is the culprit.  Unfortunately I didn't quite follow the
commit rush before code freeze, and this problem was introduced.

I've committed a fix to head (r238071), but it may take some time to MFC
to stable/9, since we've just entered code freeze.

Meanwhile, you can apply this patch:

http://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c?view=patch&r1=238071&r2=238070&pathrev=238071