This patch removes FLAC__lpc_restore_signal_16_intrin_sse2(). It's faster than C code, but not faster than MMX-accelerated ASM functions. It's also slower than the new SSE4.1 functions that were added by the previous patch. So this function wasn't very useful before, and now it's even less useful. I don't see a reason to keep it. -------------- next part -------------- A non-text attachment was scrubbed... Name: 05_remove_old_intrin_func.patch Type: application/octet-stream Size: 7183 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20170218/2d4d4edc/attachment.obj>
Olivier Tristan
2017-Feb-18 16:59 UTC
[flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code
Is the SSE 4.1 support detected at runtime ? i.e you compile with 4.1 support in order to get the intrinsincs by the compiler but the actual code is only called at runtime when 4.1 is supported by the computer Thanks ! 2017-02-18 17:56 GMT+01:00 lvqcl <lvqcl.mail at gmail.com>:> This patch removes FLAC__lpc_restore_signal_16_intrin_sse2(). > > It's faster than C code, but not faster than MMX-accelerated > ASM functions. It's also slower than the new SSE4.1 functions > that were added by the previous patch. > So this function wasn't very useful before, and now it's > even less useful. I don't see a reason to keep it. > _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev > >-- Olivier Tristan Research & Development www.uvi.net -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20170218/3cecf2ea/attachment.html>
Olivier Tristan <o.tristan at uvi.net> wrote:> Is the SSE 4.1 support detected at runtime ? > i.e you compile with 4.1 support in order to get the intrinsincs by the > compiler but the actual code >is only called at runtime when 4.1 is > supported by the computer >Correct (if the compiler isn't too outdated).
Erik de Castro Lopo
2017-Feb-19 20:20 UTC
[flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code
lvqcl wrote:> This patch removes FLAC__lpc_restore_signal_16_intrin_sse2(). > > It's faster than C code, but not faster than MMX-accelerated > ASM functions. It's also slower than the new SSE4.1 functions > that were added by the previous patch. > So this function wasn't very useful before, and now it's > even less useful. I don't see a reason to keep it.Sorry, this patch fails to apply on top of the others. Would you be able to rebase against what's currently in the tree? Thanks, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:> Sorry, this patch fails to apply on top of the others. Would > you be able to rebase against what's currently in the tree?Ok, will do it, but currently xiph git still contains old code.