flac dev - Mar 2015 - crash on lpc_restore_signal_16_intrin_sse2

On 9.3.2015 19:06, lvqcl wrote:
> Tristan Matthews wrote:
>
>> Hi,
>>
>> VLC recently migrated to libflac 1.3.1, however we had to revert to
>> 1.3.0 as we had crashes for most FLAC files on the Windows desktop
>> platform.
>>
>> More information is available here:
>> https://trac.videolan.org/vlc/ticket/14104
> Cannot reproduce the crash here.
>
> Also I downloaded VLC 2.2.0 (32-bit Windows build) and it also doesn't
crash.
>
VLC 2.2.0 crashed with exception 0xc0000005 on the first file I tried. 
But libflac itself does not, for example flac.exe and foobar2000 have no 
issues.

Janne Hyv?rinen wrote:
> VLC 2.2.0 crashed with exception 0xc0000005 on the first file I tried.
> But libflac itself does not, for example flac.exe and foobar2000 have no
> issues.
*Very* interesting.

I suspect that flac.exe and foobar2000 don't use
FLAC__lpc_restore_signal_16_intrin_sse2() function at all. This function
is not used if NASM is available; FLAC__lpc_restore_signal_asm_ia32_mmx()
is used instead.

I wonder how to debug this crash...

On 9.3.2015 20:43, lvqcl wrote:
> Janne Hyv?rinen wrote:
>
>> VLC 2.2.0 crashed with exception 0xc0000005 on the first file I tried.
>> But libflac itself does not, for example flac.exe and foobar2000 have
no
>> issues.
> *Very* interesting.
>
> I suspect that flac.exe and foobar2000 don't use
> FLAC__lpc_restore_signal_16_intrin_sse2() function at all. This function
> is not used if NASM is available; FLAC__lpc_restore_signal_asm_ia32_mmx()
> is used instead.
>
> I wonder how to debug this crash...
>
I compiled flac.exe without NASM and verified that 
FLAC__lpc_restore_signal_16_intrin_sse2 is used. Decoding the same file 
that made VLC 2.2 crash decoded without issues. Would be nice if VLC was 
compilable with MSVC and we could use its debugger.