Erik de Castro Lopo <mle+la at mega-nerd.com> ?????(?) ? ????? ?????? Sun, 31 Jan 2016 01:47:01 +0300:>> 1) Both src/share/Makefile.am and src/share/utf8/Makefile.am >> have iconvert.h inside EXTRA_DIST, although iconvert.c includes it. >> Why? > > EXTRA_DIST is for files that are not listed elsewhere in the Makefile.am > but which need to end up in the distribution tarball.So should it be moved from EXTRA_DIST into utf8_libutf8_la_SOURCES/libutf8_la_SOURCES where iconvert.c is mentioned?>> 2) What's the purpose of charsetmap.h? It seems that it's not used >> anywhere. > > It was added in 2002, but like you said is not used anywhere. > > I'll remove it.BTW, it's still referenced in EXTRA_DIST list in the above-mentioned two files.
lvqcl wrote:> So should it be moved from EXTRA_DIST into utf8_libutf8_la_SOURCES/libutf8_la_SOURCES > where iconvert.c is mentioned?Yes, it should. Fixed.> >> 2) What's the purpose of charsetmap.h? It seems that it's not used > >> anywhere. > > > > It was added in 2002, but like you said is not used anywhere. > > > > I'll remove it. > > BTW, it's still referenced in EXTRA_DIST list in the above-mentioned two files.Also fixed. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:> Also fixed. Thanks.There's also src/share/utf8/Makefile.am file that has the same issues. (I don't know why utf8 source files are included in two makefiles, one is src/share/Makefile.am and another is src/share/utf8/Makefile.am) -------------- next part -------------- A non-text attachment was scrubbed... Name: utf8_Makefile.patch Type: application/octet-stream Size: 622 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20160131/466edbf1/attachment.obj