search for: iconvert

I'm looking at an issue reported by the Coverity static analyzer. In iconvert() in src/share/utf8/iconvert.c on line 152 there is newbuf = safe_realloc_add_2op_(utfbuf, ...); If the request size is not valid, the function will free utfbuf and return 0. This is followed by goto fail and utfbuf is freed for the second time. A simply fix would be to set utfbuf to 0 if newbuf...

1) Both src/share/Makefile.am and src/share/utf8/Makefile.am have iconvert.h inside EXTRA_DIST, although iconvert.c includes it. Why? 2) What's the purpose of charsetmap.h? It seems that it's not used anywhere.

...e to update automake version from 1.7 to 1.11. This might be fixable with installing automake-1.7 for mingw, but i haven't bothered with that, and i prefer 1.11 anyway (i also doubt that silent rules work with pre-1.11). 2) Compile-time warnings: f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c: In function 'iconvert': f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:114:5: warning: passing argument 2 of 'libiconv' from incompatible pointer type [enabled by default] f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: note: e...

Hi all, I think we're getting close to the first FLAC release in over 4 years. I have tested whats currently in Git on x86, x86_64 and PowerPC Linux and would appreciate reports of successful compiles (and even more importantly any failures) on OSX, Windows and elsewhere. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo

...arset.Po' tmpdepfile='.deps/charset.TPo' \ depmode=gcc /bin/sh ../depcomp \ cc -DPACKAGE=\"vorbis-tools\" -DVERSION=\"1.0rc2\" -I. -I. -I../include -fno-common -O4 -Wall -fsigned-char -ffast-math -c `test -f charset.c || echo './'`charset.c source='iconvert.c' object='iconvert.o' libtool=no \ depfile='.deps/iconvert.Po' tmpdepfile='.deps/iconvert.TPo' \ depmode=gcc /bin/sh ../depcomp \ cc -DPACKAGE=\"vorbis-tools\" -DVERSION=\"1.0rc2\" -I. -I. -I../include -fno-common -O4 -Wall -fsigned-char -ffast-...

Erik de Castro Lopo <mle+la at mega-nerd.com> ?????(?) ? ????? ?????? Sun, 31 Jan 2016 01:47:01 +0300: >> 1) Both src/share/Makefile.am and src/share/utf8/Makefile.am >> have iconvert.h inside EXTRA_DIST, although iconvert.c includes it. >> Why? > > EXTRA_DIST is for files that are not listed elsewhere in the Makefile.am > but which need to end up in the distribution tarball. So should it be moved from EXTRA_DIST into utf8_libutf8_la_SOURCES/libutf8_la_SOURCES w...

...tadata_Chain *chain, const Operation *operation, FLAC__bool *needs_write); +FLAC__bool do_shorthand_operation__vorbis_comment(const char *filename, FLAC__bool prefix_with_filename, FLAC__Metadata_Chain *chain, const Operation *operation, FLAC__bool *needs_write, FLAC__bool raw); --- src/share/utf8/iconvert.h 1970-01-01 00:00:00 +0000 +++ src/share/utf8/iconvert.h 2007-07-15 00:55:11 +0000 @@ -0,0 +1,49 @@ +/* + * Copyright (C) 2001 Edmund Grimley Evans <edmundo@rano.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Publi...

LRN wrote: > f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:175:5: > warning: passing argument 2 of 'libiconv' from incompatible pointer > type [enabled by default] > f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: > note: expected 'const char **' but argument is of type 'char **'...

Files share/utf8/charset.c and share/utf8/iconvert.c aren't needed under Windows. The patch removes them from MSVC build system. -------------- next part -------------- A non-text attachment was scrubbed... Name: utf8.patch Type: application/octet-stream Size: 3720 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachm...

...s: charset.c, charset.h: My functions for converting between encodings, with header file. charmaps.h: Mapping tables included by charset.c. makemap.c: A program for generating a mapping table using iconv(). charset_test.c: A test suite for charset.c. Just compile it and link it with charset.o. iconvert.c: A function for converting a string using iconv(). Old files: 8859-1.map, 8859-2.map, make_code_map.pl: These are no longer used and can be removed. Things to do: Maybe modify acinclude.m4 to check that iconv() works properly. Experience with Mutt tells us that there are some severely broken...

...lac-1.1.0~/src/share/utf8/Makefile.am 2003-01-25 21:15:36 +0300 +++ flac-1.1.0/src/share/utf8/Makefile.am 2004-02-05 03:52:31 +0300 @@ -4,9 +4,9 @@ INCLUDES = -I$(top_srcdir)/include/share -noinst_LIBRARIES = libutf8.a +noinst_LTLIBRARIES = libutf8.la -libutf8_a_SOURCES = charset.c charset.h iconvert.c utf8.c +libutf8_la_SOURCES = charset.c charset.h iconvert.c utf8.c EXTRA_DIST = \ Makefile.lite \ --- flac-1.1.0~/src/test_grabbag/cuesheet/Makefile.am 2003-01-25 21:15:58 +0300 +++ flac-1.1.0/src/test_grabbag/cuesheet/Makefile.am 2004-02-05 03:52:31 +0300 @@ -25,8 +25,8 @@ test_cuesheet_SO...

lvqcl wrote: > So should it be moved from EXTRA_DIST into utf8_libutf8_la_SOURCES/libutf8_la_SOURCES > where iconvert.c is mentioned? Yes, it should. Fixed. > >> 2) What's the purpose of charsetmap.h? It seems that it's not used > >> anywhere. > > > > It was added in 2002, but like you said is not used anywhere. > > > > I'll remove it. > > BTW, it'...

...nk I'm getting a handle on the assert(). It's this one: assertion "(!k && !ibl) || (k == (size_t)(-1) && errno == E2BIG && ibl && obl < 6) || (k == (size_t)(-1) && (errno == EILSEQ || errno == EINVAL) && ibl)" failed: file "iconvert.c", line 111 In my test case, we have a plain ASCII string with a KOI8-R locale charset and this: Before the first iconv() call: * ibl = 9 * obl = utflen = 1 After the iconv() call: * k = 0, ibl = 8, obl = 0, errno = EINVAL I'm sitting here with the SUSv3 spec for iconv(), trying to mak...

...icture.c | 6 +-- .../replaygain_analysis/replaygain_analysis.c | 2 +- src/share/utf8/charset.c | 6 +-- src/share/utf8/charset.h | 6 +-- src/share/utf8/charset_test.c | 6 +-- src/share/utf8/iconvert.c | 6 +-- src/share/utf8/iconvert.h | 6 +-- src/share/utf8/makemap.c | 6 +-- src/share/utf8/utf8.c | 6 +-- src/test_grabbag/Makefile.lite | 6 +-- src/test_grabbag/c...

I''ve liked the scgi runner ever since it came out. I like the way it''scontrolled, the way it''s clusterable, and the fact that it runs onwin32 platforms so easily. Now it''s May 2006, and the scgi runner hasn''t changed since October,and now we have mongrel. I keep seeing hints of clustering in mongrel,as well. I just downloaded the win32 installer for

...studio 8\vc\include\stdio.h(234) : see declaration of 'fopen' 5> Message: 'This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_DEPRECATE. See online help for details.' 5>replaygain.c 7>charset.c 7>iconvert.c 5>c:\greenhouse\workspace\soundio\tool\flac_1.1.3\main\flac-1.1.3\src\share\grabbag\replaygain.c(82) : warning C4996: 'chmod' was declared deprecated 5> c:\program files\microsoft visual studio 8\vc\include\io.h(316) : see declaration of 'chmod' 5> Message...