similar to: questions about utf8 library

Erik de Castro Lopo <mle+la at mega-nerd.com> ?????(?) ? ????? ?????? Sun, 31 Jan 2016 01:47:01 +0300: >> 1) Both src/share/Makefile.am and src/share/utf8/Makefile.am >> have iconvert.h inside EXTRA_DIST, although iconvert.c includes it. >> Why? > > EXTRA_DIST is for files that are not listed elsewhere in the Makefile.am > but which need to end up in the

lvqcl wrote: > So should it be moved from EXTRA_DIST into utf8_libutf8_la_SOURCES/libutf8_la_SOURCES > where iconvert.c is mentioned? Yes, it should. Fixed. > >> 2) What's the purpose of charsetmap.h? It seems that it's not used > >> anywhere. > > > > It was added in 2002, but like you said is not used anywhere. > > > > I'll remove it.

Files share/utf8/charset.c and share/utf8/iconvert.c aren't needed under Windows. The patch removes them from MSVC build system. -------------- next part -------------- A non-text attachment was scrubbed... Name: utf8.patch Type: application/octet-stream Size: 3720 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20160128/c2c4ce9c/attachment.obj

Hi all, I think we're getting close to the first FLAC release in over 4 years. I have tested whats currently in Git on x86, x86_64 and PowerPC Linux and would appreciate reports of successful compiles (and even more importantly any failures) on OSX, Windows and elsewhere. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo

LRN wrote: > f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:175:5: > warning: passing argument 2 of 'libiconv' from incompatible pointer > type [enabled by default] > f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: > note: expected 'const char **' but argument is of type 'char **' Firstly, what version of

I'm looking at an issue reported by the Coverity static analyzer. In iconvert() in src/share/utf8/iconvert.c on line 152 there is newbuf = safe_realloc_add_2op_(utfbuf, ...); If the request size is not valid, the function will free utfbuf and return 0. This is followed by goto fail and utfbuf is freed for the second time. A simply fix would be to set utfbuf to 0 if newbuf is 0. However, this

Here's a propsed heavy-duty solution for your UTF-8 problems. I'm including a patch in this message, but I'll put the new files on my web site at http://rano.org/tmp/xiph_files.tar.gz I've tested this by running vorbiscomment with and without -DHAVE_ICONV=1 in vorbis-tools/share/Makefile. It seems to work. Changed files: acinclude.m4: Add a test for nl_langinfo(CODESET). This

Ok, I managed to compile the Ogg and Vorbis libs. Then, after modifying the file audio_out.c as follows: original: #include <dlfcn.h> modified: #include <win32/include/dlfcn.h> I was able to (finally!) compile libao. Then I tried to compile the module vorbis-tools, but uninvited problems came to my party. [...] > /usr/bin/ld: multiple definitions of symbol _getopt >

Hi all, I added -Wmissing-prototypes -Wstrict-prototypes to the CFLAGS and found that there were a number warnings generated. The patch below fixes those warnings and adds the two -W flags to configure.in. Cheers, Erik ----------------------8<----------------------8<---------------------- --- src/metaflac/operations_shorthand.h 1970-01-01 00:00:00 +0000 +++

Hi, And thanks for flac. There's a minor problem when compiling flac: libtool warns about mixing up shared and static libraries. Typical messages are: *** Warning: Linking the shared library libxmms-flac.la against the *** static library ../../src/plugin_common/libplugin_common.a is not portable! *** Warning: Linking the shared library libxmms-flac.la against the *** static library

src/share/utf8/utf8.c mentions that "On NT-based windows systems, we could use WideCharToMultiByte()/MultiByteToWideChar(CP_UTF8), but MS doesn't actually have a consistent API across win32". flac/metaflac don't support Win98 since ver. 1.3.0, so it's possible to use system routines to convert to/from UTF-8. I removed all fprintf(stderr...) code from the win32 code

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 26.02.2012 14:18, Erik de Castro Lopo wrote: > I ... would appreciate reports of successful compiles (and even > more importantly any failures) on ... Windows ... > 1) I have to update automake version from 1.7 to 1.11. This might be fixable with installing automake-1.7 for mingw, but i haven't bothered with that, and i prefer 1.11

The patch <https://git.xiph.org/?p=flac.git;a=commitdiff;h=b3c3e2ac4fcac9d9b178ad240976634d52d5eece> removed Makefile.am files from subdirs of src/share, but for some reasom didn't remove src/share/utf8/Makefile.am. This file is not included into release tarballs, so I think it's indeed unnecessary. It's better to remove it than let it bit-rot. -------------- next part

fullcheck target was removed from test/Makefile.am, but not from <root>/Makefile.am. So `make fullcheck' fails with the following message: ... *** No rule to make target `fullcheck'. Stop. ...

Some projects/makefiles add both 'include' and 'include/share' to the list of additional include directories. For example, src/share/utf8/utf8.c includes 'include/share/alloc.h' as "share/alloc.h" but 'include/share/utf8.h' as just "utf8.h". Also src/share/replaygain_analysis/replaygain_analysis.c includes "replaygain_analysis.h", not

Erik de Castro Lopo wrote: > lvqcl wrote: > >> The set of four patches that remove dependency of libFLAC on win_utf8_io. >> >> Tested only on Windows, with MSVC and MSYS/MinGW (both autotools and makefile.lite) >> >> Please review, especially makefile patches, I'm not very familiar with them. > > Applied. All good. Thanks. But the 1st patch

--- COPYING.GPL | 43 +++++++++++----------- doc/Makefile.am | 6 +-- doc/Makefile.lite | 6 +-- examples/c/decode/file/Makefile.am | 6 +-- examples/c/decode/file/Makefile.lite | 6 +-- examples/c/decode/file/main.c | 6 +--

On 5/24/14, lvqcl <lvqcl.mail at gmail.com> wrote: > Ozkan Sezer <sezeroz at gmail.com> ?????(?) ? ????? ?????? Sat, 24 May 2014 > 10:16:15 +0400: > >> - changes the _MSC_VER condition to universally _WIN32: MSVC, as well >> as GCC supports this. > > MSYS/MinGW 4.8.3, 4.9.0 can't compile code from git after this patch: > > format.c:47:22: error:

Josh, The two Makefile.ams that you added recently: examples/c/decode/file/Makefile.am examples/cpp/decode/file/Makefile.am are generating errors like this: examples/c/decode/file/Makefile.am:22: blank line following trailing backslash examples/cpp/decode/file/Makefile.am:22: blank line following trailing backslash The attached patch fixes these. Erik --

Dear FLAC devs, I would like to get some of our patches merged into master. Most of them deal with adhering to GNU conventions, respectively not overriding flags/variables that are up to the user to set. For instance, honoring $(htmldir) is important, as we have installation paths for the documentation that differ from what is currently coded in the various Makefile.am's. Regards David