search for: xyesyes

...ure.ac | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..4347c07 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,10 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) + if test "$host_os" = "mingw32" ; then + XIPH_ADD_CFLAGS([-mstackrealign]) + fi fi - fi XIPH_ADD_CFLAGS([-Wextra]) -- 2.1.0

On Fri, Apr 10, 2015 at 1:40 PM, lvqcl <lvqcl.mail at gmail.com> wrote: > Tristan Matthews wrote: > > > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > > XIPH_ADD_CFLAGS([-msse2]) > > - XIPH_ADD_CFLAGS([-mstackrealign]) > > + if test "$host_os" = "mingw32" ; then > > + XIPH_ADD_CFLAGS([-mstackrealign]) > > +...

...ertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index eb9b0cc..e7d68c3 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then > > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > XIPH_ADD_CFLAGS([-msse2]) > - XIPH_ADD_CFLAGS([-mstackrealign]) > fi > + fi > > +if test "$host_os" = "mingw32" ; then > + XIPH_ADD_CFLAGS([-mstackrealign]) > fi > > XIPH_ADD_CFLAGS([-Wextra]) Everyone happy with this p...

Tristan Matthews wrote: > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > XIPH_ADD_CFLAGS([-msse2]) > - XIPH_ADD_CFLAGS([-mstackrealign]) > + if test "$host_os" = "mingw32" ; then > + XIPH_ADD_CFLAGS([-mstackrealign]) > + fi > fi But sse_os==no doesn't prevent libFLAC from using SSE intrinsics. So I th...

...c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..8dd5b0d 100644 --- a/configure.ac +++ b/configure.ac @@ -399,11 +399,16 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) fi - fi +case "$host_os" in + "mingw32"|"os2") + if test "$host_cpu" = "i686"; then + XIPH_ADD_CFLAGS([-mstackrealign]) + fi +esac + XIPH_ADD_CFLAGS([-Wextra])...

...ever. libFLAC detects CPU SSE support in runtime, so --disable-sse is necessary for cuch CPUs only because it disables -msse2 switch. Maybe it makes sense to add new switch, --no-force-sse2 or --disable-force-sse2 or similar? And replace if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi with if test "x$force_sse2" = "xyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi ?

if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi -msse2 tells the compiler that it can generate SSE2 instructions. The resulting code will _not_ run on CPUs without SSE2. This is counter to the assembly optimizations themselves, which check at runtime if extensions like S...

On 03/14/16 03:51 PM, lvqcl wrote: > With --disable-sse, FLAC__SSE_OS is undefined and FLAC__cpu_info() uses > sigemptyset/sigaction to determine OS SSE support. That's not quite right as I have to build binaries with --disable-sse (I build and distribute both with and without) so that some users on PII's don't get a sigill, even though the OS supports SSE. So it seems to

Dave Yeo wrote: > Doesn't SSE support imply SSE2+ support? Not for the CPU. Just because a CPU supports SSE, does not mean it is guaranteed to support SSE2+. For OS support, I'm not sure. Didn't later version of SSE add new registers? > I have a '96 install of an OS, it has been upgraded until end of life, > and it handles SSE4+ instructions fine even though the

...ELP_STRING([--disable-sse], [Disable SSE if the OS does not support SSE instructions]), [case "${enableval}" in yes) sse_os=yes ;; no) sse_os=no ;; *) AC_MSG_ERROR(bad value ${enableval} for --enable-sse) ;; esac],[sse_os=yes]) if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi So maybe it's better to rename it to --disable-sse2 or --disable-forced-sse2 or --no-force-sse2? (and rename 'sse_os' to 'use_sse2' or 'forced-sse2' ?) Or least the description should be updated so that it reflects the cur...