search for: sse_o

1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, even if x86intrin.h is not available. 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': AM_CONDITIONAL(FLaC__SSE_OS, test "x$sse_os" = xtrue) It seems that it should be changed to AM_CONDITIONAL(FLaC__SSE_OS, test "x$sse_os" = xyes) 3) configure --disable-sse prints...

--- configure.ac | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..4347c07 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,10 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) + if test "$host_os" = "mingw32" ; then + XIPH_ADD_CFLAGS([-mstackrealign]) + fi fi - fi XIPH_ADD_CFLAGS([-Wextra]) -- 2.1.0

On Fri, Apr 10, 2015 at 1:40 PM, lvqcl <lvqcl.mail at gmail.com> wrote: > Tristan Matthews wrote: > > > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > > XIPH_ADD_CFLAGS([-msse2]) > > - XIPH_ADD_CFLAGS([-mstackrealign]) > > + if test "$host_os" = "mingw32" ; then > > + XIPH_ADD_CFLAGS([-mstackrealign]) > &g...

...tually, it wasn't fully correct even before this). *Currently all it does is disables -msse2 flag* The relevant parts of configure.ac: AC_ARG_ENABLE(sse, AC_HELP_STRING([--disable-sse], [Disable SSE if the OS does not support SSE instructions]), [case "${enableval}" in yes) sse_os=yes ;; no) sse_os=no ;; *) AC_MSG_ERROR(bad value ${enableval} for --enable-sse) ;; esac],[sse_os=yes]) if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi So maybe it's better to rename it to --disable-sse2 or --disable-forced-sse...

lvqcl wrote: > lvqcl wrote: > > > 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, > > even if x86intrin.h is not available. > > > > 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': > > The patch is attached. Please check it. Looks good. I need to do a little testing. > > 3) configure --disable-sse prints: > > " SSE optimizations : ................... no&...

...1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index eb9b0cc..e7d68c3 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then > > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > XIPH_ADD_CFLAGS([-msse2]) > - XIPH_ADD_CFLAGS([-mstackrealign]) > fi > + fi > > +if test "$host_os" = "mingw32" ; then > + XIPH_ADD_CFLAGS([-mstackrealign]) > fi > > XIPH_ADD_CFLAGS([-Wextra]) Eve...

lvqcl wrote: > 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, > even if x86intrin.h is not available. > > 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': The patch is attached. Please check it. > 3) configure --disable-sse prints: > " SSE optimizations : ................... no" > but this option actually doesn't disable SSE, s...

Tristan Matthews wrote: > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > XIPH_ADD_CFLAGS([-msse2]) > - XIPH_ADD_CFLAGS([-mstackrealign]) > + if test "$host_os" = "mingw32" ; then > + XIPH_ADD_CFLAGS([-mstackrealign]) > + fi > fi But sse_os==no doesn't prevent libFLAC from using...

configure.ac still has two places that aren't fully correct: 1) it creates incorrect definition of FLAC__HAS_X86INTRIN in config.h file. 2)AM_CONDITIONAL(FLaC__SSE_OS...) compares sse_os with 'true' instead of 'yes'. -------------- next part -------------- A non-text attachment was scrubbed... Name: conf_ac.patch Type: application/octet-stream Size: 1074 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/2015022...

...686. --- configure.ac | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..8dd5b0d 100644 --- a/configure.ac +++ b/configure.ac @@ -399,11 +399,16 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) fi - fi +case "$host_os" in + "mingw32"|"os2") + if test "$host_cpu" = "i686"; then + XIPH_ADD_CFLAGS([-mstackrealign]) + fi +esac + XIPH...

...CPUs seem to live forever. libFLAC detects CPU SSE support in runtime, so --disable-sse is necessary for cuch CPUs only because it disables -msse2 switch. Maybe it makes sense to add new switch, --no-force-sse2 or --disable-force-sse2 or similar? And replace if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi with if test "x$force_sse2" = "xyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi ?

The source release for 1.0.1 is finally up on sourceforge. If you are compiling for x86 make sure to read the note in in the README about automake 1.5. Josh __________________________________________________ Do You Yahoo!? Find the one for you at Yahoo! Personals http://personals.yahoo.com

if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi -msse2 tells the compiler that it can generate SSE2 instructions. The resulting code will _not_ run on CPUs without SSE2. This is counter to the assembly optimizations themselves, which check at runti...

Erik de Castro Lopo wrote: > Sow what about just: > > echo " Compiler is Clang : ................... ${xiph_cv_c_compiler_clang}" > - echo " SSE optimizations : ................... ${sse_os}" > + echo " SSE enabled : ......................... ${sse_enabled}" > echo " Asm optimizations : ................... ${asm_optimisation}" > echo " Ogg/FLAC support : .................... ${have_ogg}" What is the definitio...

> lvqcl wrote: > >> 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, >> even if x86intrin.h is not available. >> >> 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': > > The patch is attached. Please check it. Ping. Is the fix of FLAC__HAS_X86INTRIN definition necessary? Anyway I think that it should not be _always_ defined (as it does now).

On 03/14/16 03:51 PM, lvqcl wrote: > With --disable-sse, FLAC__SSE_OS is undefined and FLAC__cpu_info() uses > sigemptyset/sigaction to determine OS SSE support. That's not quite right as I have to build binaries with --disable-sse (I build and distribute both with and without) so that some users on PII's don't get a sigill, even though the OS supp...

Dave Yeo wrote: > Doesn't SSE support imply SSE2+ support? Not for the CPU. Just because a CPU supports SSE, does not mean it is guaranteed to support SSE2+. For OS support, I'm not sure. Didn't later version of SSE add new registers? > I have a '96 install of an OS, it has been upgraded until end of life, > and it handles SSE4+ instructions fine even though the