flac dev - May 2013 - flac 1.3.0pre3 pre-release

Dagobert Michelsen wrote:
> Yes, C99 is on and according to B.2.18 from
>   http://docs.oracle.com/cd/E19205-01/819-5265/bjapp/index.html
> also casual use. What does not work is the inclusion of a static function
> from extern inline. It also does work if I declare bitwriter_grow_ also
> as "inline".
I actually think SUN/Oracle Studio is doing the wrong thing here as
GCC, Clang and MSVC all accept the code as is.

I'm happy to see a SUN/Oracle Studio specific fix for this, but it should
not change the code for all the compilers where this currently works.

 
> Would the other patch about MIN and MAX substitution acceptable or should I
> add a patch with a autoconf-detection?
That should be fixed in commit 2de567fb11ce3bbb711d993922d69af6d2cf817f.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Hi Erik,

Am 07.04.2013 um 12:25 schrieb Erik de Castro Lopo <mle+la at
mega-nerd.com>:
> Dagobert Michelsen wrote:
>> Yes, C99 is on and according to B.2.18 from
>>  http://docs.oracle.com/cd/E19205-01/819-5265/bjapp/index.html
>> also casual use. What does not work is the inclusion of a static
function
>> from extern inline. It also does work if I declare bitwriter_grow_ also
>> as "inline".
> 
> I actually think SUN/Oracle Studio is doing the wrong thing here as
> GCC, Clang and MSVC all accept the code as is.
> 
> I'm happy to see a SUN/Oracle Studio specific fix for this, but it
should
> not change the code for all the compilers where this currently works.
Something like this?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Sun-Studio-can-not-include-static-function-from-exte.patch
Type: application/octet-stream
Size: 847 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20130526/d6cc9a45/attachment.obj
-------------- next part --------------


I found one more issue on Solaris 10 Sparc, where TIOCGWINSZ is defined in
termios.h. Fortunately there is an autoconf-idiom for that as documented in
 
http://www.gnu.org/software/autoconf/manual/autoconf.html#index-AC_005fHEADER_005fTIOCGWINSZ-661

The following patch adds the functionality:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Use-location-of-TIOCGWINSZ-from-autoconf-manual.patch
Type: application/octet-stream
Size: 1120 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20130526/d6cc9a45/attachment-0001.obj
-------------- next part --------------


I hope they can still get in to 1.3.0.


Best regards

  -- Dago

-- 
"You don't become great by trying to be great, you become great by
wanting to do something,
and then doing it so hard that you become great in the process." - xkcd
#896

Dagobert Michelsen wrote:
> Hi Erik,
> 
> Am 07.04.2013 um 12:25 schrieb Erik de Castro Lopo <mle+la at
mega-nerd.com>:
> > Dagobert Michelsen wrote:
> >> Yes, C99 is on and according to B.2.18 from
> >>  http://docs.oracle.com/cd/E19205-01/819-5265/bjapp/index.html
> >> also casual use. What does not work is the inclusion of a static
function
> >> from extern inline. It also does work if I declare bitwriter_grow_
also
> >> as "inline".
> > 
> > I actually think SUN/Oracle Studio is doing the wrong thing here as
> > GCC, Clang and MSVC all accept the code as is.
> > 
> > I'm happy to see a SUN/Oracle Studio specific fix for this, but it
should
> > not change the code for all the compilers where this currently works.
> 
> Something like this?
Ugly but yes :-).

Both applied.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/