flac dev - May 2013 - FLAC currently won't compile for Android [bisected]

2013/5/15 Ulrich Klauer <ulrich at chirlu.de>
> Felix Homann wrote:
>
> > Yes, HAVE_SYS_PARAM_H is set in config.h:
>
> OK ... Yet still I don't see how a change in
> src/libFLAC/include/private/macros.h could affect src/flac/utils.c in
> any way.
>
> Anyone got an idea?


I haven't spend too much attention to the errors when bisecting, sorry!
The first bad commit 03a9e6064d406e3656afacdbe50e8e47ebfa0de3 yields a
different error:

CCLD     flac
../../src/libFLAC/.libs/libFLAC.so: error: undefined reference to 'MIN'
../../src/libFLAC/.libs/libFLAC.so: error: undefined reference to 'MAX'
collect2: error: ld returned 1 exit status
make[3]: *** [flac] Fehler 1

Regards,

Felix
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20130515/f0d728d9/attachment.htm

Here are the warnings I get with 03a9e6064d406e3656afacdbe50e8e47ebfa0de3:

LANG=C android-make | grep Warning
bitreader.c: In function 'FLAC__bitreader_skip_bits_no_crc':
bitreader.c:494:4: warning: implicit declaration of function 'MIN'
[-Wimplicit-function-declaration]
bitreader.c:494:4: warning: nested extern declaration of 'MIN'
[-Wnested-externs]
bitwriter.c: In function 'FLAC__bitwriter_write_zeroes':
bitwriter.c:277:3: warning: implicit declaration of function 'MIN'
[-Wimplicit-function-declaration]
bitwriter.c:277:3: warning: nested extern declaration of 'MIN'
[-Wnested-externs]
fixed.c: In function 'FLAC__fixed_compute_best_predictor':
fixed.c:241:2: warning: implicit declaration of function 'MIN'
[-Wimplicit-function-declaration]
fixed.c:241:2: warning: nested extern declaration of 'MIN'
[-Wnested-externs]
fixed.c:241:19: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
fixed.c:243:24: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
fixed.c:245:24: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
fixed.c: In function 'FLAC__fixed_compute_best_predictor_wide':
fixed.c:303:19: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
fixed.c:305:24: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
fixed.c:307:24: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
format.c: In function
'FLAC__format_get_max_rice_partition_order_from_blocksize':
format.c:535:2: warning: implicit declaration of function 'MIN'
[-Wimplicit-function-declaration]
format.c:535:2: warning: nested extern declaration of 'MIN'
[-Wnested-externs]
md5.c: In function 'format_input_':
md5.c:282:25: warning: cast increases required alignment of target type
[-Wcast-align]
md5.c:288:24: warning: cast increases required alignment of target type
[-Wcast-align]
metadata_iterators.c: In function 'copy_n_bytes_from_file_':
metadata_iterators.c:3122:3: warning: implicit declaration of function
'MIN' [-Wimplicit-function-declaration]
metadata_iterators.c:3122:3: warning: nested extern declaration of 'MIN'
[-Wnested-externs]
stream_decoder.c: In function 'read_residual_partitioned_rice_':
stream_decoder.c:2716:2: warning: implicit declaration of function 'MAX'
[-Wimplicit-function-declaration]
stream_decoder.c:2716:2: warning: nested extern declaration of 'MAX'
[-Wnested-externs]
stream_encoder.c: In function 'init_stream_internal_':
stream_encoder.c:677:4: warning: implicit declaration of function 'MAX'
[-Wimplicit-function-declaration]
stream_encoder.c:677:4: warning: nested extern declaration of 'MAX'
[-Wnested-externs]
stream_encoder.c: In function 'FLAC__stream_encoder_process':
stream_encoder.c:1957:3: warning: implicit declaration of function 'MIN'
[-Wimplicit-function-declaration]
stream_encoder.c:1957:3: warning: nested extern declaration of 'MIN'
[-Wnested-externs]
ogg_decoder_aspect.c: In function
'FLAC__ogg_decoder_aspect_read_callback_wrapper':
ogg_decoder_aspect.c:210:5: warning: implicit declaration of function
'MAX'
[-Wimplicit-function-declaration]
ogg_decoder_aspect.c:210:5: warning: nested extern declaration of 'MAX'
[-Wnested-externs]
decode.c: In function 'write_callback':
decode.c:965:28: warning: cast increases required alignment of target type
[-Wcast-align]
decode.c:966:28: warning: cast increases required alignment of target type
[-Wcast-align]
decode.c:967:28: warning: cast increases required alignment of target type
[-Wcast-align]
decode.c:968:28: warning: cast increases required alignment of target type
[-Wcast-align]
encode.c:118:34: warning: cast increases required alignment of target type
[-Wcast-align]
encode.c:119:33: warning: cast increases required alignment of target type
[-Wcast-align]
../../src/libFLAC/.libs/libFLAC.so: error: undefined reference to 'MIN'
../../src/libFLAC/.libs/libFLAC.so: error: undefined reference to 'MAX'
collect2: error: ld returned 1 exit status
make[3]: *** [flac] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20130515/c88407e0/attachment-0001.htm

Felix Homann wrote:
> Here are the warnings I get with 03a9e6064d406e3656afacdbe50e8e47ebfa0de3:
It seems Android sys/param.h doesn't define MIN/MAX.

Could you try to revert this commit on current master (or simply  
change line 35 of src/libFLAC/include/private/macros.h back to
#if defined(__GNUC__)
) and recompile? Or possibly bisect 03a9e60..master to find out when  
the src/flac/utils.c error starts to appear?

Ulrich