search for: stream_encoder

...global declaration /usr/include/sys/signal.h:407: warning: shadowed declaration is here md5.c: In function 'FLAC__MD5Accumulate': md5.c:394: warning: declaration of 'signal' shadows a global declaration /usr/include/sys/signal.h:407: warning: shadowed declaration is here CC stream_encoder.lo stream_encoder.c: In function 'evaluate_constant_subframe_': stream_encoder.c:3454: warning: declaration of 'signal' shadows a global declaration /usr/include/sys/signal.h:407: warning: shadowed declaration is here stream_encoder.c: In function 'evaluate_fixed_subframe_':...

...erformance with standard encoding levels and 16-bit files as the 17-bit side channel can still be processed with the 32-bit accumulator and correctly selects the 64-bit accumulator with very large 16-bit partitions. This is related to commits 6f7ec60c and 187e596e. --- src/libFLAC/include/private/stream_encoder.h | 6 ++++++ src/libFLAC/stream_encoder.c | 14 ++++++-------- src/libFLAC/stream_encoder_intrin_sse2.c | 3 ++- src/libFLAC/stream_encoder_intrin_ssse3.c | 3 ++- 4 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/libFLAC/include/private/stream_encoder....

...01: unresolved external symbol _snprintf grabbag_static.lib(stream_decoder.obj) : error LNK2001: unresolved external symbol _FLAC__lpc_restore_signal_asm_ia32_mmx grabbag_static.lib(stream_decoder.obj) : error LNK2001: unresolved external symbol _FLAC__lpc_restore_signal_asm_ia32 grabbag_static.lib(stream_encoder.obj) : error LNK2001: unresolved external symbol _FLAC__fixed_compute_best_predictor_asm_ia32_mmx_cmov grabbag_static.lib(stream_encoder.obj) : error LNK2001: unresolved external symbol _FLAC__lpc_compute_residual_from_qlp_coefficients_asm_ia32_mmx grabbag_static.lib(stream_encoder.obj) : error LNK...

Erik de Castro Lopo wrote: > Applied with minor reformatting. Thanks. And btw, about reformatting: currently stream_encoder.c contains the following code: #ifdef FLAC__SSSE3_SUPPORTED if(encoder->private_->cpuinfo.ia32.ssse3) aaaaa; else #endif #ifdef FLAC__SSE2_SUPPORTED bbbbb; #endif This code is correct because if FLAC__SSSE3_SUPPORTED is defined then FLAC__SSE2_SUPPORTED is also defined (there are no c...

...ary when bits-per-sample + log2(blocksize) > 30" I mean the word "statistically". libFLAC uses FLAC__fixed_compute_best_predictor_wide() if "bits_per_sample + FLAC__bitmath_ilog2(blocksize)+1 > 30" is true (see encoder->private_->use_wide_by_block variable in stream_encoder.c)

...he value of qlp_coeff_precision to make sure that 32-bit math is enough for decoding of 16-bit audio. subframe_bps can be equal to 17 for 16-bit input (for side channel). So the value of subframe_bps should be compared with 17, not 16 (see also http://git.xiph.org/?p=flac.git;a=blob;f=src/libFLAC/stream_encoder.c;hb=02591f6b4b09e7c6e26bd2ae7225ff2810b227bb#l3431 ) -------------- next part -------------- A non-text attachment was scrubbed... Name: stream_encoder_bps.patch Type: application/octet-stream Size: 1543 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20151012/...

...end of the mail reduced average fragmentation to two fragments per file and decode speeds were as good as without fragmentation. I don't know how big issue this is in *nix environments but added buffering would definitely be a nice change for the Windows frontend. diff --git a/src/libFLAC/stream_encoder.c b/src/libFLAC/stream_encoder.c index 6f46d78..bd95634 100644 --- a/src/libFLAC/stream_encoder.c +++ b/src/libFLAC/stream_encoder.c @@ -1288,6 +1288,8 @@ static FLAC__StreamEncoderInitStatus init_FILE_internal_( if(file == stdout) file = get_binary_stdout_(); /* just to be safe */...

...r St?neberg wrote: > > > I finally got around to trying to update FLAC for the MAME/MESS > > project again. There were several issues I was able to fix and will > > submit patches later, but I hit one roadblock with GCC and clang: > > > > src/lib/libflac/libFLAC/stream_encoder.c:1696:43: error: cast from function call > > of type 'double' to non-matching type 'FLAC__int32' (aka 'int') > > [-Werror,-Wbad-function-cast] > > ...FLAC__int32 tukey_parts = (FLAC__int32)strtod(specification+14, 0); > >...

Hi all, I have tagged 1.3.0pre4 in git and provided a tarball here: http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre4.tar.xz I have built and tested the git tree on: linux-x86_64 openbsd5-i386 freebsd5-i386 as well as successfully cross compiling from Linux to 32 and 64 bit MinGW. As far as I am concerned, the only thing left to do for this release is to update the

...stumbled on a possible overflow. The reason this has not come up earlier is because the encoder only hits this point when the estimate of the rice_parameter is very much off. To trigger this overflow, one has to force rice_parameter to 0 in for example the function evaluate_lpc_subframe in libFLAC/stream_encoder.c. When encoding noisy material, which needs a high rice parameter, it can happen that the return value of that function overflows. When this happens, the wrong order might be picked, and the file blows up to enormous proportions. In my case, about 30 times the size of the original WAV file. When...

Hi, I've been trying to use the FLAC lib for c++. I need to implement basic encoder function in my application, so i tried to include encoder.h , set everything to the default path, and included stream_encoder.cpp,stream encoder.cpp files in the project. Include is #include "FLAC++/encoder.h" i write something like this FLAC::Encoder::File test; i build, compile goes ok but then i get [Linker Error] Unresolved external '_FLAC__stream_encoder_set_ogg_serial_number' referenced from H...

On Thu, Jun 19, 2014 at 06:25:57PM +0400, lvqcl wrote: > Now I wonder why evaluate_lpc_subframe_() function in stream_encoder.c contains > almost the same code, but without any comments that it's not enough pessimistic: > evaluate_lpc_subframe_(): > > if(subframe_bps + qlp_coeff_precision + FLAC__bitmath_ilog2(order) <= 32) > if(subframe_bps <= 16 && qlp_coeff_precision <= 16) >...

...<<subframe->qlp_coeff_precision)-1) < (((FLAC__uint64)-1) << 32) ) > */ > if(bps + subframe->qlp_coeff_precision + FLAC__bitmath_ilog2(order) <= 32) > > Is it really "not pessimistic enough"? Can it be changed similarly to your patch > for stream_encoder.c? Good question. I'm not sure what exactly Josh meant by that comment. The git message says just "minor comments". I think the right size of the expression was meant to be (FLAC__uint64)1<<32, otherwise it doesn't make much sense to me. With that it can rewritten in log2...

MSVS profiler shows that the following code in stream_encoder.c takes several percent of CPU time: for(rice_parameter = 0, k = partition_samples; k < mean; rice_parameter++, k <<= 1) ; this code is equivalent to: rice_parameter = 0; k = partition_samples; while(k < mean) { rice_parameter++; k <<= 1; }...

Hi, I finally got around to trying to update FLAC for the MAME/MESS project again. There were several issues I was able to fix and will submit patches later, but I hit one roadblock with GCC and clang: src/lib/libflac/libFLAC/stream_encoder.c:1696:43: error: cast from function call of type 'double' to non-matching type 'FLAC__int32' (aka 'int') [-Werror,-Wbad-function-cast] ...FLAC__int32 tukey_parts = (FLAC__int32)strtod(specification+14, 0); ^~~~~~~~~~...

...nested-externs] stream_decoder.c: In function 'read_residual_partitioned_rice_': stream_decoder.c:2716:2: warning: implicit declaration of function 'MAX' [-Wimplicit-function-declaration] stream_decoder.c:2716:2: warning: nested extern declaration of 'MAX' [-Wnested-externs] stream_encoder.c: In function 'init_stream_internal_': stream_encoder.c:677:4: warning: implicit declaration of function 'MAX' [-Wimplicit-function-declaration] stream_encoder.c:677:4: warning: nested extern declaration of 'MAX' [-Wnested-externs] stream_encoder.c: In function 'FLAC__s...

Miroslav Lichvar wrote: > In the precompute_partition_info_sums_ function, instead of selecting > 64-bit accumulator when the signal bps is larger than 16, revert to the > original approach based on partition size, but make room for few extra > bits to not overflow with unusual signals where the average residual > magnitude may be larger than bps. > > It slightly improves

lvqcl wrote: > Erik de Castro Lopo wrote: > >>> It slightly improves the performance with standard encoding levels and >>> 16-bit files as the 17-bit side channel can still be processed with the >>> 32-bit accumulator and correctly selects the 64-bit accumulator with >>> very large 16-bit partitions. >>> >>> This is related to commits

...sion steps. However, some faulty code was too severely restricting the possible steps. This patch lifts the restriction to match a restriction coded a little further in the process. This doesn't make using -p worth your while, but at least it doesn't create larger files now --- src/libFLAC/stream_encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libFLAC/stream_encoder.c b/src/libFLAC/stream_encoder.c index 9dfb0c5..8d4cfcc 100644 --- a/src/libFLAC/stream_encoder.c +++ b/src/libFLAC/stream_encoder.c @@ -3428,9 +3428,9 @@ FLAC__bool process_subframe_( }...

I found that 32-bit total_error_* variables in fixed_compute_best_predictor() functions can overflow. For example it happens with the attached test.wav and the following options: "-l 0 -b 4200 -m -r 5". The attached patch should fix it. (Now all three use_wide_by_* variables are unused, so I commented them out with #ifdef 0). -------------- next part -------------- A non-text