search for: metadata_iterators

...wrote: > Win_utf8 stuff should not be included in libflac since it's only to be used > by the flac.exe frontend. It is not needed by other programs nor would they > benefit from it without doing the extra work of converting their ansi > filenames and functions to utf-8. libFLAC.a(metadata_iterators.release.o): In function `simple_iterator_prime_input_': flac/src/libFLAC/metadata_iterators.c:427: undefined reference to `fopen_utf8' flac/src/libFLAC/metadata_iterators.c:424: undefined reference to `fopen_utf8' libFLAC.a(metadata_iterators.release.o): In function `set_file_stats_'...

...grabbag_static, replaygain_analysis_static, replaygain_synthesis_static, utf8_static, win_utf8_io_static Both 'libFLAC_static' and 'libFLAC_dynamic' projects depend (only) on 'win_utf8_io_static'. I tried to remove this dependency and libFLAC_dynamic failed to compile since metadata_iterators.c uses e.g. flac_fopen, which is defined in share/compat.h as fopen_utf8. metadata_iterators.obj : error LNK2001: unresolved external symbol unlink_utf8 metadata_iterators.obj : error LNK2001: unresolved external symbol fopen_utf8 metadata_iterators.obj : error LNK2001: unresolved externa...

...gs" ) ])# XIPH_GCC_STACK_PROTECTOR For the Linux -> Windows cross compile for instance, this detects SSP as working, but when I compile it fails with: CC stream_encoder_framing.lo CC window.lo CCLD libFLAC.la Creating library file: .libs/libFLAC.dll.a .libs/metadata_iterators.o:metadata_iterators.c:(.text+0x8d): undefined reference to `___stack_chk_guard' .libs/metadata_iterators.o:metadata_iterators.c:(.text+0x121): undefined reference to `___stack_chk_guard' .libs/metadata_iterators.o:metadata_iterators.c:(.text+0x14f): undefined reference to `___stack_chk...

Janne Hyv?rinen wrote: > Patch v2, now handles more malformed cases. Original patch was for a > file for which I had a sample from a user but this allows handling some > manually broken test cases. Err, I'm getting warning messages on that patch: CC metadata_iterators.lo metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?: metadata_iterators.c:2238:12: error: comparison between ?FLAC__Metadata_SimpleIteratorStatus? and ?enum <anonymous>? [-Werror=enum-compare] if(status == FLAC__METADATA_CHAIN_STATUS_BAD_METADATA) goto skip;...

...inux Have you tried static building too? I just tried a bunch of switches for ../configure and both "--enable-static" as well as "--disable-shared --enable-static" fails for me on Kubuntu 12.04 64-bit with the following error > [...] > CC memory.lo > CC metadata_iterators.lo > metadata_iterators.c: In function 'set_file_stats_': > metadata_iterators.c:3298:2: warning: ignoring return value of > 'chown', declared with attribute warn_unused_result [-Wunused-result] > metadata_iterators.c:3299:2: warning: ignoring return value of > '...

My patch for metadata_iterators didn't completely fix the problem. The behavior of chain_prepare_for_write_() must always be the same as the behavior of FLAC__metadata_chain_check_if_tempfile_needed(). Currently it's not the case: one check was missed in FLAC__metadata_chain_check_if_tempfile_needed(), and also chain_pr...

...?rinen wrote: > >> Patch v2, now handles more malformed cases. Original patch was for a >> file for which I had a sample from a user but this allows handling some >> manually broken test cases. > > Err, I'm getting warning messages on that patch: > > CC metadata_iterators.lo > metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?: > metadata_iterators.c:2238:12: error: comparison between ?FLAC__Metadata_SimpleIteratorStatus? and ?enum <anonymous>? [-Werror=enum-compare] > if(status == FLAC__METADATA_CHAIN_STATUS_BAD_METADA...

Hi all, I finally managed to bite the bullet and roll a pre-release. Its here: http://downloads.xiph.org/releases/flac/beta/ I have personally tested this code on: x86-linux x86_64-linux powerpc-linux I have not yet done any work on making sure the changelog is up-to-date. That will be done between now and the release. What I'm after now is testing of this source tarball

Janne Hyv?rinen wrote: > Win_utf8 stuff should not be included in libflac since it's only to be > used by the flac.exe frontend. It is not needed by other programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >>

Here's a patch to allow flac and metaflac handle files with malformed vorbiscomment metadata block. -------------- next part -------------- diff --git a/src/libFLAC/metadata_iterators.c b/src/libFLAC/metadata_iterators.c index d50df39..39cb276 100644 --- a/src/libFLAC/metadata_iterators.c +++ b/src/libFLAC/metadata_iterators.c @@ -78,7 +78,7 @@ static FLAC__Metadata_SimpleIteratorStatus read_metadata_block_data_padding_cb_( static FLAC__Metadata_SimpleIteratorStatus read_metada...

Erik de Castro Lopo wrote: > JonY wrote: > > > Please do a link time test instead, I am not getting this error and > > would like to keep stack protector on. > > I'll write an m4 macro. I have attampted to write a macro that reliably detects the availability of stack smash protection. I currently have two configurations where my detection says that SSP is available

Some libcs like uClibc-ng can optionally disable deprecated functions. utime is one of them. When done so, both the header and the function go missing. This fixes flac_utime to work in such a situation. --- include/share/compat.h | 10 +++++++++- src/libFLAC/metadata_iterators.c | 9 +++++++-- src/share/grabbag/file.c | 9 +++++++-- 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/include/share/compat.h b/include/share/compat.h index f3041655..a063c083 100644 --- a/include/share/compat.h +++ b/include/share/compat.h @@ -112,9 +112,13 @@ #include...

...Windows cross compile for instance, this detects >> SSP as working, but when I compile it fails with: >> >> CC stream_encoder_framing.lo >> CC window.lo >> CCLD libFLAC.la >> Creating library file: .libs/libFLAC.dll.a >> .libs/metadata_iterators.o:metadata_iterators.c:(.text+0x8d): undefined reference to `___stack_chk_guard' >> .libs/metadata_iterators.o:metadata_iterators.c:(.text+0x121): undefined reference to `___stack_chk_guard' >> .libs/metadata_iterators.o:metadata_iterators.c:(.text+0x14f): undefined refere...

-------- Original Message -------- Subject: [flac:bugs] #407 Error in md5.c Date: Sat, 07 Dec 2013 15:19:16 +0000 To: [flac:bugs] <407 at bugs.flac.p.re.sf.net> I shouldn't have hurried to post this issue. There are more: metadata_iterator.c around line 1213: function returns without freeing node, so node leaks metadata_iterator.c around line 1415: function returns without

...gt; Patch v2, now handles more malformed cases. Original patch was for a >>> file for which I had a sample from a user but this allows handling some >>> manually broken test cases. >> >> Err, I'm getting warning messages on that patch: >> >> CC metadata_iterators.lo >> metadata_iterators.c: In function >> ?read_metadata_block_data_vorbis_comment_cb_?: >> metadata_iterators.c:2238:12: error: comparison between >> ?FLAC__Metadata_SimpleIteratorStatus? and ?enum <anonymous>? >> [-Werror=enum-compare] >> if(status...

...ibrary (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that klibc contains so many improvements I think this is exceptable. --- include/FLAC/ordinals.h | 17 +++++++++-------- src/flac/main.c | 2 +- src/libFLAC/metadata_iterators.c | 2 +- src/libFLAC/metadata_object.c | 2 +- src/share/grabbag/cuesheet.c | 2 +- src/test_libFLAC/metadata_manip.c | 2 +- 6 files changed, 14 insertions(+), 13 deletions(-) diff --git a/include/FLAC/ordinals.h b/include/FLAC/ordinals.h index 80d055b..dc2dafc 100644 --- a...

...x86 machine. Edgy comes standard with gcc-4.1 and I'm getting a number of warnings: memory.c: In function 'FLAC__memory_alloc_aligned': memory.c:52: warning: cast from pointer to integer of different size memory.c:52: warning: cast to pointer from integer of different size metadata_iterators.c: In function 'read_metadata_block_data_picture_cb_': metadata_iterators.c:2370: warning: dereferencing type-punned pointer will break strict-aliasing rules metadata_object.c: In function 'FLAC__metadata_object_new': metadata_object.c:504: warning: dereferencing type-...

...xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20140926/54a4a32b/attachment-0001.htm -------------- next part -------------- diff --git a/src/libFLAC/metadata_iterators.c b/src/libFLAC/metadata_iterators.c index d50df39..cba864c 100644 --- a/src/libFLAC/metadata_iterators.c +++ b/src/libFLAC/metadata_iterators.c @@ -77,8 +77,8 @@ static FLAC__Metadata_SimpleIteratorStatus read_metadata_block_data_streaminfo_c static FLAC__Metadata_SimpleIteratorStatus read_metada...

...t.c:535:2: warning: nested extern declaration of 'MIN' [-Wnested-externs] md5.c: In function 'format_input_': md5.c:282:25: warning: cast increases required alignment of target type [-Wcast-align] md5.c:288:24: warning: cast increases required alignment of target type [-Wcast-align] metadata_iterators.c: In function 'copy_n_bytes_from_file_': metadata_iterators.c:3122:3: warning: implicit declaration of function 'MIN' [-Wimplicit-function-declaration] metadata_iterators.c:3122:3: warning: nested extern declaration of 'MIN' [-Wnested-externs] stream_decoder.c: In function...

...CC md5.lo > md5.c: In function 'format_input_': > md5.c:282:25: warning: cast increases required alignment of target > type [-Wcast-align] > md5.c:288:24: warning: cast increases required alignment of target > type [-Wcast-align] > CC memory.lo > CC metadata_iterators.lo > metadata_iterators.c: In function > 'write_metadata_block_data_cuesheet_cb_': > metadata_iterators.c:2714:41: warning: declaration of 'index' shadows > a global declaration [-Wshadow] > CC metadata_object.lo > metadata_object.c: In function > '...