flac dev - Jan 2013 - /usr/include/FLAC no longer searched for headers

I've received a bugreport that vlc doesn't compile with the current
flac. The problem seems to be that it includes "stream_decoder.h"
instead of "FLAC/stream_decoder.h". This no longer works due to the
commit b76d4f (it was discussed on this list).

I'm not sure how many clients are relying on the directory to be
searched by default, but I think it might be worth mentioning in the
changelog.

-- 
Miroslav Lichvar

Miroslav Lichvar wrote:
> I've received a bugreport that vlc doesn't compile with the current
> flac. The problem seems to be that it includes "stream_decoder.h"
> instead of "FLAC/stream_decoder.h". This no longer works due to
the
> commit b76d4f (it was discussed on this list).
> 
> I'm not sure how many clients are relying on the directory to be
> searched by default, but I think it might be worth mentioning in the
> changelog.
Thats weird, the flac source tree in git doesn't seem to have a
changelog file. Instead its on the flac-website tree.

Just to re-iterate, this change was made because FLAC installs
a file name $prefix/FLAC/alloc.h and then if the client code
uses

     gcc -I$prefix/FLAC ...,

then the flac alloc.h gets included in preference to the system
alloc.h.

After this change, the correct way to include flac headers in
C and C++ files is:

     #include <FLAC/stream_decoder.h>

or

     #include "FLAC/stream_decoder.h"

Not sure how to handle this. The changelog.html file on the web site
should only be updated when the relase happens. Where do we keep
changelog entries before the release?

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

It seems the changelog.html file in the doc/html/-directory in the 
flac.git has been used for that purpose, as it mentions a 1.2.2 release 
without a release data

On 02-01-13 19:59, Erik de Castro Lopo wrote:
> Miroslav Lichvar wrote:
>
>> I've received a bugreport that vlc doesn't compile with the
current
>> flac. The problem seems to be that it includes
"stream_decoder.h"
>> instead of "FLAC/stream_decoder.h". This no longer works due
to the
>> commit b76d4f (it was discussed on this list).
>>
>> I'm not sure how many clients are relying on the directory to be
>> searched by default, but I think it might be worth mentioning in the
>> changelog.
> Thats weird, the flac source tree in git doesn't seem to have a
> changelog file. Instead its on the flac-website tree.
>
> Just to re-iterate, this change was made because FLAC installs
> a file name $prefix/FLAC/alloc.h and then if the client code
> uses
>
>       gcc -I$prefix/FLAC ...,
>
> then the flac alloc.h gets included in preference to the system
> alloc.h.
>
> After this change, the correct way to include flac headers in
> C and C++ files is:
>
>       #include <FLAC/stream_decoder.h>
>
> or
>
>       #include "FLAC/stream_decoder.h"
>
> Not sure how to handle this. The changelog.html file on the web site
> should only be updated when the relase happens. Where do we keep
> changelog entries before the release?
>
> Erik