search for: stream_decod

To avoid crash caused by an unbound LPC decoding when predictor order is larger than blocksize, the sanity check needs to be moved to the subframe decoding functions. --- src/libFLAC/stream_decoder.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/src/libFLAC/stream_decoder.c b/src/libFLAC/stream_decoder.c index d13b23b..211b4db 100644 --- a/src/libFLAC/stream_decoder.c +++ b/src/libFLAC/stream_decoder.c @@ -1281,9 +1281,6 @@ FLAC__bool a...

I've received a bugreport that vlc doesn't compile with the current flac. The problem seems to be that it includes "stream_decoder.h" instead of "FLAC/stream_decoder.h". This no longer works due to the commit b76d4f (it was discussed on this list). I'm not sure how many clients are relying on the directory to be searched by default, but I think it might be worth mentioning in the changelog. -- Miroslav...

...C__HAS_ID3LIB=1 -DID3LIB_MAJOR=3 -DID3LIB_MINOR=7 -DID3LIB_PATCH=13 -DSIZEOF_SHORT=2 -DSIZEOF_INT=4 -DSIZEOF_LONG=4 -DSIZEOF_LONG_LONG=8 -I. -I. -I../.. -I./include -I../../include -O3 -DNDEBUG -fomit-frame-pointer -funroll-loops -finline-functions -Wall -W -Winline -DFLaC__INLINE=__inline__ -c stream_decoder.c -Wp,-MD,.deps/stream_decoder.TPlo -fno-common -DPIC -o .libs/stream_decoder.lo stream_decoder.c:22: header file 'ogg/ogg.h' not found stream_decoder.c:58: undefined type, found `ogg_stream_state' Any ideas? It would probably be best if the makefiles were changed to put the CFL...

In function read_metadata_vorbiscomment_ from stream_decoder.c, at various locations where we short circuit the computation, we also set `obj->num_comments` accordingly. For example: https://git.xiph.org/?p=flac.git;a=blob;f=src/libFLAC/stream_decoder.c;h=e0f1b14d30dd548268a88e4341af3f38290816e3;hb=HEAD#l1736 https://git.xiph.org/?p=flac.git;a=blob;f=s...

Hi all, I'm trying to compile the flac-1.1.1 tarball on a Linux PPC system (a G3 iBook running Debian Testing). Configure is fine, but make bombs out almost immediately with: lpc_asm.s: Assembler messages: lpc_asm.s:1: Error: junk at end of line, first unrecognized character is `l' lpc_asm.s:2: Error: junk at end of line, first unrecognized character is `C' lpc_asm.s:4:

It's a port of two patches from 1.2.1 maintenance branch: http://flac.cvs.sourceforge.net/viewvc/flac/flac/src/libFLAC/stream_decoder.c?r1=1.147&r2=1.147.2.1&pathrev=FLAC_RELEASE_1_2_1_MAINTENANCE_BRANCH http://flac.cvs.sourceforge.net/viewvc/flac/flac/src/libFLAC/stream_decoder.c?r1=1.147.2.1&r2=1.147.2.2&pathrev=FLAC_RELEASE_1_2_1_MAINTENANCE_BRANCH -------------- next part -------------- A non-text attachmen...

I don't understand the comment in src/libFLAC/stream_decoder.c: /*@@@@@@ technically not pessimistic enough, should be more like if( (FLAC__uint64)order * ((((FLAC__uint64)1)<<bps)-1) * ((1<<subframe->qlp_coeff_precision)-1) < (((FLAC__uint64)-1) << 32) ) */ if(bps + subframe->qlp_coeff_precision + FLAC__bitmath_ilog2(or...

There are 2 comments in stream_decoder.c that mention FLAC__lpc_restore_signal_asm_ia32_mmx() requirement for the output array. The text is updated to include intrinsic functions too. -------------- next part -------------- A non-text attachment was scrubbed... Name: 06_decoder_comment.patch Type: application/octet-stream Size: 1673 b...

...==================================================== RCS file: /cvsroot/flac/flac/include/FLAC/file_decoder.h,v retrieving revision 1.13 diff -u -r1.13 file_decoder.h --- file_decoder.h 26 Jan 2002 17:36:39 -0000 1.13 +++ file_decoder.h 6 May 2002 15:07:21 -0000 @@ -22,6 +22,10 @@ #include "stream_decoder.h" +#ifdef __cplusplus +extern "C" { +#endif + typedef enum { FLAC__FILE_DECODER_OK = 0, FLAC__FILE_DECODER_SEEKING, /*@@@ NOTE: unused; remove this in the next minor-version */ @@ -133,5 +137,9 @@ FLAC__bool FLAC__file_decoder_process_remaining_frames(FLAC__FileDecoder...

...w it can seek in > files > > that have large id3 tag (or any random data) at the end and it > won't loop on > > streams with shuffled frames. > > One small patch on top of that and it's bug free. ;) > > -- > Miroslav Lichvar > > --- flac/src/libFLAC/stream_decoder.c.orig 2006-11-03 > 18:52:38.104291323 +0100 > +++ flac/src/libFLAC/stream_decoder.c 2006-11-03 18:53:41.350727144 > +0100 > @@ -2995,7 +2995,7 @@ > > while(1) { > /* check if the bounds are still ok */ > - if (lower_bound_sample + FLAC__MIN_BLOCK_SIZE > upper_b...

On Mon, Apr 20, 2015 at 08:00:20PM +0300, lvqcl wrote: > I don't understand the comment in src/libFLAC/stream_decoder.c: > > /*@@@@@@ technically not pessimistic enough, should be more like > if( (FLAC__uint64)order * ((((FLAC__uint64)1)<<bps)-1) * ((1<<subframe->qlp_coeff_precision)-1) < (((FLAC__uint64)-1) << 32) ) > */ > if(bps + subframe->qlp_coeff_precision...

...c -o md5.o >/dev/null 2>&1 mv -f .libs/md5.lo md5.lo /bin/sh ../../libtool --mode=compile gcc -DPACKAGE=\"flac\" -DVERSION=\"0.8\" -I. -I. -I./include -I ../../include -Wall -W -O3 -fomit-frame-pointer -funroll-loops -ffast-math -finline-functions -DNDEBUG -c stream_decoder.c rm -f .libs/stream_decoder.lo gcc -DPACKAGE=\"flac\" -DVERSION=\"0.8\" -I. -I. -I./include -I ../../include -Wall -W -O3 -fomit-frame-pointer -funroll-loops -ffast-math -finline-functions -DNDEBUG -Wp,-MD,.deps/stream_decoder.pp -c stream_decoder.c -fPIC -DPIC -o .libs/s...

...ren't properly linked in, I haven't the time to investigate the > issue > yet=/) > > > More verbose report about the no altivec bug: > > If I disable altivec optimization (with --disable-asm-optimizations > --disable-altivec) > > the result is: > > stream_decoder.c: In function `FLAC__stream_decoder_init': > stream_decoder.c:296: error: `FLAC__lpc_restore_signal' undeclared > (first use in this function) > stream_decoder.c:296: error: (Each undeclared identifier is reported > only once > stream_decoder.c:296: error: for each funct...

I have noticed lpc slowdown both in encoding and decoding, not related to new config.h stuff. It seems there is wrong choosing of fastest possible version of lpc function. Patch is attached. -- Miroslav Lichvar -------------- next part -------------- Index: src/libFLAC/stream_decoder.c =================================================================== RCS file: /cvsroot/flac/flac/src/libFLAC/stream_decoder.c,v retrieving revision 1.70 diff -u -r1.70 stream_decoder.c --- src/libFLAC/stream_decoder.c 18 Oct 2002 05:49:20 -0000 1.70 +++ src/libFLAC/stream_decoder.c 20 Oct 2002...

FYI, I have checked in a few interesting things. One is a speedup to the decoder (about 15% improvement in overall decode time). Another is a new interface to FLAC file metadata. If you're curious look at include/FLAC/metadata.h. It is basically a collection of object manipulation routines and iterators that make it pretty easy to add/edit/delete FLAC metadata in files efficiently. The

..."xmms twitch" test, checked in to CVS. thanks! Thanks! I see you have changed the channels and bps setting, this doesn't work when the decoder hasn't decoded a frame. There should be a fallback for this case. -- Miroslav Lichvar -------------- next part -------------- Index: stream_decoder.c =================================================================== RCS file: /cvsroot/flac/flac/src/libFLAC/stream_decoder.c,v retrieving revision 1.119 diff -u -r1.119 stream_decoder.c --- stream_decoder.c 6 Nov 2006 16:48:33 -0000 1.119 +++ stream_decoder.c 7 Nov 2006 09:13:30 -0000 @@ -2935...

Hi, I obtain the following error messages when trying to compile flac 1.2.1 under MinGW : gcc -DHAVE_CONFIG_H -I. -I. -I../.. -DFLaC__INLINE=__inline__ -DNDEBUG -I../.. -I./include -I../../include -O3 -funroll-loops -finline-functions -Wall -W -Winl ine -g -O2 -MT stream_decoder.lo -MD -MP -MF .deps/stream_decoder.Tpo -c stream_ decoder.c -DDLL_EXPORT -DPIC -o .libs/stream_decoder.o In file included from stream_decoder.c:56: ../../include/share/alloc.h:41:5: #error In file included from stream_decoder.c:56: ../../include/share/alloc.h: In function `safe_malloc_mul_2op...

Don't use the assembly function since it seems to be slower than the current version of FLAC__bitreader_read_rice_signed_block. --- src/libFLAC/stream_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libFLAC/stream_decoder.c b/src/libFLAC/stream_decoder.c index f987c27..37934de 100644 --- a/src/libFLAC/stream_decoder.c +++ b/src/libFLAC/stream_decoder.c @@ -400,7 +400,7 @@ static FLAC__StreamDecoderInitStatus init_strea...

...MAJOR=3 -DID3LIB_MINOR=7 > -DID3LIB_PATCH=13 -DSIZEOF_SHORT=2 -DSIZEOF_INT=4 -DSIZEOF_LONG=4 > -DSIZEOF_LONG_LONG=8 -I. -I. -I../.. -I./include -I../../include -O3 > -DNDEBUG -fomit-frame-pointer -funroll-loops -finline-functions -Wall > > -W -Winline -DFLaC__INLINE=__inline__ -c stream_decoder.c > -Wp,-MD,.deps/stream_decoder.TPlo -fno-common -DPIC -o > .libs/stream_decoder.lo > stream_decoder.c:22: header file 'ogg/ogg.h' not found > stream_decoder.c:58: undefined type, found `ogg_stream_state' > > Any ideas? It would probably be best if the makefile...

...ld get you > enough to narrow it down. OK, here's the stack trace: (gdb) bt #0 FLAC__bitbuffer_read_raw_uint32 (bb=0x20000000008c8048, val=0x80000fffffffa498, bits=24, read_callback=0x20000000003b1008, client_data=0x60000000002beb20) at bitbuffer.c:1107 #1 0x2000000000123dc0 in stream_decoder_read_metadata_ ( decoder=0x60000000002beb20) at stream_decoder.c:633 #2 0x2000000000123300 in FLAC__stream_decoder_process_metadata ( decoder=0x60000000002beb20) at stream_decoder.c:427 #3 0x4000000000010320 in write_callback (encoder=0x60000000002b8290, buffer=0x60000000002f9df0 &...