--- Josh Coalson <xflac@yahoo.com> wrote:> > -- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > On Tue, Dec 17, 2002 at 01:01:08PM -0800, Josh Coalson wrote: > > > --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > > > Ok, what about enabling the 3dnow function in libFLAC by > default? > > > > I think time has shown the function is bugfree... :) > > > > > > Yeah, I just haven't done it because I don't remember hearing > > > feedback from others about using it (or maybe I just forgot... > > > has anyone else built flac 1.0.4 with ./configure --enable-3dnow > ?) > > > Also I don't have an AMD to test it on. > > > > > > If the current test suite (CVS as of last night) works for you > > > though it is probably OK. > > > > I have a problem with make check: > > ... > > make[3]: Entering directory > `/home/lichvarm/tmp/flac/flac-test/test' > > Makefile:310: *** Recursive variable `TESTS_ENVIRONMENT' references > > itself (eventually). Stop. > > make[3]: Leaving directory `/home/lichvarm/tmp/flac/flac-test/test' > > make[2]: *** [check-am] Error 2 > > ... > > Oops, I'll fix that soon.fixed in CVS.> > So i ran "make -f Makefile.lite release" in test directory. All > have > > passed (except test_bins.sh, there was no test_files/bins/ > > directory). > > OK, I'll make it the default in 1.0.5now the default. Josh __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com
On Tue, Dec 17, 2002 at 01:01:08PM -0800, Josh Coalson wrote:> --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > Ok, what about enabling the 3dnow function in libFLAC by default? > > I think time has shown the function is bugfree... :) > > Yeah, I just haven't done it because I don't remember hearing > feedback from others about using it (or maybe I just forgot... > has anyone else built flac 1.0.4 with ./configure --enable-3dnow ?) > Also I don't have an AMD to test it on. > > If the current test suite (CVS as of last night) works for you > though it is probably OK.I have a problem with make check: ... make[3]: Entering directory `/home/lichvarm/tmp/flac/flac-test/test' Makefile:310: *** Recursive variable `TESTS_ENVIRONMENT' references itself (eventually). Stop. make[3]: Leaving directory `/home/lichvarm/tmp/flac/flac-test/test' make[2]: *** [check-am] Error 2 ... So i ran "make -f Makefile.lite release" in test directory. All have passed (except test_bins.sh, there was no test_files/bins/ directory). And it took 6 hours of CPU time, it is really exhaustive :). -- Miroslav Lichvar
> -- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > On Tue, Dec 17, 2002 at 01:01:08PM -0800, Josh Coalson wrote: > > --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > > Ok, what about enabling the 3dnow function in libFLAC by default? > > > I think time has shown the function is bugfree... :) > > > > Yeah, I just haven't done it because I don't remember hearing > > feedback from others about using it (or maybe I just forgot... > > has anyone else built flac 1.0.4 with ./configure --enable-3dnow ?) > > Also I don't have an AMD to test it on. > > > > If the current test suite (CVS as of last night) works for you > > though it is probably OK. > > I have a problem with make check: > ... > make[3]: Entering directory `/home/lichvarm/tmp/flac/flac-test/test' > Makefile:310: *** Recursive variable `TESTS_ENVIRONMENT' references > itself (eventually). Stop. > make[3]: Leaving directory `/home/lichvarm/tmp/flac/flac-test/test' > make[2]: *** [check-am] Error 2 > ...Oops, I'll fix that soon.> So i ran "make -f Makefile.lite release" in test directory. All have > passed (except test_bins.sh, there was no test_files/bins/ > directory).OK, I'll make it the default in 1.0.5> And it took 6 hours of CPU time, it is really exhaustive :).Yeah, I've written up a lot more tests to get better coverage. About 30% of the code in flac is test code. Josh __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com