Ok, what about enabling the 3dnow function in libFLAC by default? I think time has shown the function is bugfree... :) -- Miroslav Lichvar
--- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote:> Ok, what about enabling the 3dnow function in libFLAC by default? > I think time has shown the function is bugfree... :)Yeah, I just haven't done it because I don't remember hearing feedback from others about using it (or maybe I just forgot... has anyone else built flac 1.0.4 with ./configure --enable-3dnow ?) Also I don't have an AMD to test it on. If the current test suite (CVS as of last night) works for you though it is probably OK. Josh __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com
On Tue, Dec 17, 2002 at 01:01:08PM -0800, Josh Coalson wrote:> --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > Ok, what about enabling the 3dnow function in libFLAC by default? > > I think time has shown the function is bugfree... :) > > Yeah, I just haven't done it because I don't remember hearing > feedback from others about using it (or maybe I just forgot... > has anyone else built flac 1.0.4 with ./configure --enable-3dnow ?) > Also I don't have an AMD to test it on. > > If the current test suite (CVS as of last night) works for you > though it is probably OK.I guess there is a typo in src/test_libFLAC++/metadata_object.cpp ... metadata_object.cpp: In function `void init_metadata_blocks_()': metadata_object.cpp:180: integer constant out of range metadata_object.cpp:180: warning: decimal integer constant is so large that it is unsigned make[3]: *** [metadata_object.o] Error 1 make[3]: Leaving directory I will run the test suite. -- Miroslav Lichvar
On Tue, Dec 17, 2002 at 01:01:08PM -0800, Josh Coalson wrote:> --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > Ok, what about enabling the 3dnow function in libFLAC by default? > > I think time has shown the function is bugfree... :) > > Yeah, I just haven't done it because I don't remember hearing > feedback from others about using it (or maybe I just forgot... > has anyone else built flac 1.0.4 with ./configure --enable-3dnow ?) > Also I don't have an AMD to test it on. > > If the current test suite (CVS as of last night) works for you > though it is probably OK.I have a problem with make check: ... make[3]: Entering directory `/home/lichvarm/tmp/flac/flac-test/test' Makefile:310: *** Recursive variable `TESTS_ENVIRONMENT' references itself (eventually). Stop. make[3]: Leaving directory `/home/lichvarm/tmp/flac/flac-test/test' make[2]: *** [check-am] Error 2 ... So i ran "make -f Makefile.lite release" in test directory. All have passed (except test_bins.sh, there was no test_files/bins/ directory). And it took 6 hours of CPU time, it is really exhaustive :). -- Miroslav Lichvar