search for: metadata_object

...st-align] > CC memory.lo > CC metadata_iterators.lo > metadata_iterators.c: In function > 'write_metadata_block_data_cuesheet_cb_': > metadata_iterators.c:2714:41: warning: declaration of 'index' shadows > a global declaration [-Wshadow] > CC metadata_object.lo > metadata_object.c: In function > 'FLAC__metadata_object_vorbiscomment_replace_comment': > metadata_object.c:1275:13: warning: declaration of 'index' shadows a > global declaration [-Wshadow] > metadata_object.c: In function > 'FLAC__metadata_object_cues...

...o integer of different size memory.c:52: warning: cast to pointer from integer of different size metadata_iterators.c: In function 'read_metadata_block_data_picture_cb_': metadata_iterators.c:2370: warning: dereferencing type-punned pointer will break strict-aliasing rules metadata_object.c: In function 'FLAC__metadata_object_new': metadata_object.c:504: warning: dereferencing type-punned pointer will break strict-aliasing rules metadata_object.c: In function 'FLAC__metadata_object_clone': metadata_object.c:548: warning: dereferencing type-punned pointer...

...or maybe I just forgot... > has anyone else built flac 1.0.4 with ./configure --enable-3dnow ?) > Also I don't have an AMD to test it on. > > If the current test suite (CVS as of last night) works for you > though it is probably OK. I guess there is a typo in src/test_libFLAC++/metadata_object.cpp ... metadata_object.cpp: In function `void init_metadata_blocks_()': metadata_object.cpp:180: integer constant out of range metadata_object.cpp:180: warning: decimal integer constant is so large that it is unsigned make[3]: *** [metadata_object.o] Error 1 make[3]: Leaving directory I will...

...arning: cast to pointer from integer of different > size > > metadata_iterators.c: In function > 'read_metadata_block_data_picture_cb_': > metadata_iterators.c:2370: warning: dereferencing type-punned > pointer will > break strict-aliasing rules > > metadata_object.c: In function 'FLAC__metadata_object_new': > metadata_object.c:504: warning: dereferencing type-punned pointer > will break > strict-aliasing rules > metadata_object.c: In function 'FLAC__metadata_object_clone': > metadata_object.c:548: warning: derefere...

There are two functions: static void vorbiscomment_entry_array_delete_(FLAC__StreamMetadata_VorbisComment_Entry *object_array, unsigned num_comments); and static void cuesheet_track_array_delete_(FLAC__StreamMetadata_CueSheet_Track *object_array, unsigned num_tracks); which first dereference object_array and only then check it for NULL: free(object_array[i].indices);

Ok, what about enabling the 3dnow function in libFLAC by default? I think time has shown the function is bugfree... :) -- Miroslav Lichvar

.../operations.c | 3 +++ src/metaflac/operations_shorthand_cuesheet.c | 3 +++ src/metaflac/operations_shorthand_streaminfo.c | 3 +++ src/share/grabbag/cuesheet.c | 3 +++ src/test_libFLAC/encoders.c | 3 +++ src/test_libFLAC/metadata_object.c | 3 +++ src/test_libs_common/metadata_utils.c | 3 +++ src/test_seeking/main.c | 3 +++ 10 files changed, 30 insertions(+), 0 deletions(-) diff --git a/examples/c/decode/file/main.c b/examples/c/decode/file/main.c index e5138b4..f7efd9a 10064...

Hi all, The latest pre-release is here: http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz but there will probably need to be at least one more. I've tested this on x86_64-linux powerpc-linux i386-openbsd5.2 i386-freebsd9 The majority of changes since the last pre-release is the addition of Janne Hyv?rinen's utf8 I/O functionality. Janne's

...ed by klibc. Considering the age of EMX and lack of testing and that klibc contains so many improvements I think this is exceptable. --- include/FLAC/ordinals.h | 17 +++++++++-------- src/flac/main.c | 2 +- src/libFLAC/metadata_iterators.c | 2 +- src/libFLAC/metadata_object.c | 2 +- src/share/grabbag/cuesheet.c | 2 +- src/test_libFLAC/metadata_manip.c | 2 +- 6 files changed, 14 insertions(+), 13 deletions(-) diff --git a/include/FLAC/ordinals.h b/include/FLAC/ordinals.h index 80d055b..dc2dafc 100644 --- a/include/FLAC/ordinals.h +++ b/include/FLA...

...ms/plugin.c | 4 ++++ src/plugin_xmms/tag.c | 4 ++++ src/share/grabbag/alloc.c | 4 ++++ src/test_libFLAC++/encoders.cpp | 4 ++++ src/test_libFLAC++/main.cpp | 4 ++++ src/test_libFLAC++/metadata.cpp | 4 ++++ src/test_libFLAC++/metadata_object.cpp | 4 ++++ src/utils/flactimer/main.cpp | 4 ++++ 15 files changed, 60 insertions(+) diff --git a/src/libFLAC++/metadata.cpp b/src/libFLAC++/metadata.cpp index e03acf3..d6fff06 100644 --- a/src/libFLAC++/metadata.cpp +++ b/src/libFLAC++/metadata.cpp @@ -31,6 +31,10 @@ */ #define...

...-u -r1.7 metadata.h --- src/test_libFLAC/metadata.h 2 Feb 2007 06:58:24 -0000 1.7 +++ src/test_libFLAC/metadata.h 16 Apr 2007 10:24:34 -0000 @@ -22,5 +22,7 @@ #include "FLAC/ordinals.h" FLAC__bool test_metadata(void); +FLAC__bool test_metadata_file_manipulation(void); +FLAC__bool test_metadata_object(void) ; #endif diff -u -r1.25 metadata_object.c --- src/test_libFLAC/metadata_object.c 2 Feb 2007 06:58:24 -0000 1.25 +++ src/test_libFLAC/metadata_object.c 16 Apr 2007 10:24:38 -0000 @@ -23,6 +23,7 @@ #include "FLAC/assert.h" #include "FLAC/metadata.h" #include "test...

Function FLAC__metadata_object_delete_data() in libFLAC/metadata_object.c: it frees a pointer, then assigns 0 to it. But it doesn't do it for data.vorbis_comment.comments and object->data.cue_sheet.tracks. The patch adds assignment to zero for them. -------------- next part -------------- A non-text attachment was scrubb...

...this also. Yes, i know, but it should not be very expensive to compute it. > > In some libFLAC files isn't including of config.h. > Which ones? I hope, i see right, bitbuffer.c bitmath.c cpu.c crc.c file_decoder.c file_encoder.c fixed.c format.c lpc.c memory.c metadata_iterators.c metadata_object.c seekable_stream_decoder.c seekable_stream_encoder.c stream_decoder.c stream_encoder.c stream_encoder_framing.c -- Miroslav Lichvar

...=compile /opt/crosstool/gcc-3.4.1-glibc-2.2.5/armv5b-softfloat-linux/bin/armv5b-softfloat-linux-gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I./include -I../../include -O2 -DNDEBUG -O3 -fomit-frame-pointer -funroll-loops -finline-functions -Wall -W -Winline -DFLaC__INLINE=__inline__ -g -O2 -MT metadata_object.lo -MD -MP -MF ".deps/metadata_object.Tpo" -c -o metadata_object.lo metadata_object.c; \ then mv -f ".deps/metadata_object.Tpo" ".deps/metadata_object.Plo"; else rm -f ".deps/metadata_object.Tpo"; exit 1; fi /opt/crosstool/gcc-3.4.1-glibc-2.2.5/armv5b-softf...

...t; > In some libFLAC files isn't including of config.h. > > Which ones? > > I hope, i see right, > > bitbuffer.c > bitmath.c > cpu.c > crc.c > file_decoder.c > file_encoder.c > fixed.c > format.c > lpc.c > memory.c > metadata_iterators.c > metadata_object.c > seekable_stream_decoder.c > seekable_stream_encoder.c > stream_decoder.c > stream_encoder.c > stream_encoder_framing.c I don't think they are required in all those; I will make a pass over the source soon to check that it is included where it needs to be. Josh ___________...

The gcc version #ifdef fix for bswap16 doesn't work for Apple's clang. Here's a better fix, which has configure check for it directly. Fixes build failures on MacOS X. -r -------------- next part --------------

I have few notes: It seems there is changed API in CVS again. So, what about adding function like unsigned FLAC__format_frame_size(const FLAC__Frame *frame) which returns size of the frame in bytes. This can be useful, for example, in xmms plugin to display current bitrate like vorbis plugin does. If 'PERFORMER' field is missing in vorbis comment, it would be nice to display

Erik de Castro Lopo wrote: > JonY wrote: > > > Please do a link time test instead, I am not getting this error and > > would like to keep stack protector on. > > I'll write an m4 macro. I have attampted to write a macro that reliably detects the availability of stack smash protection. I currently have two configurations where my detection says that SSP is available

...t;, "true" }; --- src/test_libFLAC/metadata.h 2007-07-14 08:45:49 +0000 +++ src/test_libFLAC/metadata.h 2007-07-15 01:26:07 +0000 @@ -22,5 +22,7 @@ #include "FLAC/ordinals.h" FLAC__bool test_metadata(void); +FLAC__bool test_metadata_file_manipulation(void); +FLAC__bool test_metadata_object(void) ; #endif --- src/test_libFLAC/metadata_manip.c 2007-07-14 08:45:49 +0000 +++ src/test_libFLAC/metadata_manip.c 2007-07-15 01:24:02 +0000 @@ -42,6 +42,7 @@ #include "share/grabbag.h" #include "test_libs_common/file_utils_flac.h" #include "test_libs_common/metada...

...\program files\microsoft visual studio 8\vc\include\stdio.h(234) : see declaration of 'fopen' 16> Message: 'This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_DEPRECATE. See online help for details.' 16>metadata_object.c 16>c:\greenhouse\workspace\soundio\tool\flac_1.1.3\main\flac-1.1.3\src\test_libflac\metadata_object.c(488) : warning C4996: 'strdup' was declared deprecated 16> c:\program files\microsoft visual studio 8\vc\include\string.h(205) : see declaration of 'strdup' 16>...