Hello,
I borrowed dovecot parser for email addresses and going to use it in new
perl module as replacement for Email::Address. During implementation and
testing I found bugs in dovecot parser & generator. So I'm sending my
patches together with tests.
Pali Roh?r (7):
lib-mail: message_address_write: Fix generating empty group list
lib-mail: message_address_write: Fix generating group list with empty
name
lib-mail: parse_addr_spec: Like in rfc822_skip_comment() check if
last_comment is not NULL
lib-mail: parse_addr_spec: Email address without local-part is
invalid
lib-mail: parse_mailbox: Set display name instead mailbox when
parsing failed
lib-mail: message_address_write: Quote and escape strings if needed
lib-mail: Update tests for message address
src/lib-mail/message-address.c | 99 +++++++++++++++++++++++++++++++----
src/lib-mail/test-message-address.c | 11 +++-
2 files changed, 98 insertions(+), 12 deletions(-)
--
1.7.9.5
aki.tuomi at dovecot.fi
2016-Apr-03 10:45 UTC
[PATCH 0/7] Fixes for lib-mail message-address
> On April 2, 2016 at 6:58 PM Pali Roh?r <pali.rohar at gmail.com> wrote: > > > Hello, > > I borrowed dovecot parser for email addresses and going to use it in new > perl module as replacement for Email::Address. During implementation and > testing I found bugs in dovecot parser & generator. So I'm sending my > patches together with tests. > > Pali Roh?r (7): > lib-mail: message_address_write: Fix generating empty group list > lib-mail: message_address_write: Fix generating group list with empty > name > lib-mail: parse_addr_spec: Like in rfc822_skip_comment() check if > last_comment is not NULL > lib-mail: parse_addr_spec: Email address without local-part is > invalid > lib-mail: parse_mailbox: Set display name instead mailbox when > parsing failed > lib-mail: message_address_write: Quote and escape strings if needed > lib-mail: Update tests for message address > > src/lib-mail/message-address.c | 99 > +++++++++++++++++++++++++++++++---- > src/lib-mail/test-message-address.c | 11 +++- > 2 files changed, 98 insertions(+), 12 deletions(-) > > -- > 1.7.9.5Hi! Did you post the patches somewhere as they do not seem to have made it thru. Aki Tuomi Dovecot Oy
On Sunday 03 April 2016 12:45:23 aki.tuomi at dovecot.fi wrote:> > On April 2, 2016 at 6:58 PM Pali Roh?r <pali.rohar at gmail.com> > > wrote: > > > > > > Hello, > > > > I borrowed dovecot parser for email addresses and going to use it > > in new perl module as replacement for Email::Address. During > > implementation and testing I found bugs in dovecot parser & > > generator. So I'm sending my patches together with tests. > > > > Pali Roh?r (7): > > lib-mail: message_address_write: Fix generating empty group list > > lib-mail: message_address_write: Fix generating group list with > > empty > > > > name > > > > lib-mail: parse_addr_spec: Like in rfc822_skip_comment() check if > > > > last_comment is not NULL > > > > lib-mail: parse_addr_spec: Email address without local-part is > > > > invalid > > > > lib-mail: parse_mailbox: Set display name instead mailbox when > > > > parsing failed > > > > lib-mail: message_address_write: Quote and escape strings if > > needed lib-mail: Update tests for message address > > > > src/lib-mail/message-address.c | 99 > > > > +++++++++++++++++++++++++++++++---- > > > > src/lib-mail/test-message-address.c | 11 +++- > > 2 files changed, 98 insertions(+), 12 deletions(-) > > Hi! > > Did you post the patches somewhere as they do not seem to have made > it thru. > > Aki Tuomi > Dovecot OyHi! I sent all patches to ML, but dovecot server refused them. I already contacted dovecot-owner@ about this problem, but without response yet. -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: <http://dovecot.org/pipermail/dovecot/attachments/20160403/da23adeb/attachment-0001.sig>