Hello, I borrowed dovecot parser for email addresses and going to use it in new perl module as replacement for Email::Address. During implementation and testing I found bugs in dovecot parser & generator. So I'm sending my patches together with tests. Pali Roh?r (7): lib-mail: message_address_write: Fix generating empty group list lib-mail: message_address_write: Fix generating group list with empty name lib-mail: parse_addr_spec: Like in rfc822_skip_comment() check if last_comment is not NULL lib-mail: parse_addr_spec: Email address without local-part is invalid lib-mail: parse_mailbox: Set display name instead mailbox when parsing failed lib-mail: message_address_write: Quote and escape strings if needed lib-mail: Update tests for message address src/lib-mail/message-address.c | 99 +++++++++++++++++++++++++++++++---- src/lib-mail/test-message-address.c | 11 +++- 2 files changed, 98 insertions(+), 12 deletions(-) -- 1.7.9.5
On Monday 04 April 2016 19:12:56 Pali Roh?r wrote:> Hello, > > I borrowed dovecot parser for email addresses and going to use it in new > perl module as replacement for Email::Address. During implementation and > testing I found bugs in dovecot parser & generator. So I'm sending my > patches together with tests. > > Pali Roh?r (7): > lib-mail: message_address_write: Fix generating empty group list > lib-mail: message_address_write: Fix generating group list with empty > name > lib-mail: parse_addr_spec: Like in rfc822_skip_comment() check if > last_comment is not NULL > lib-mail: parse_addr_spec: Email address without local-part is > invalid > lib-mail: parse_mailbox: Set display name instead mailbox when > parsing failed > lib-mail: message_address_write: Quote and escape strings if needed > lib-mail: Update tests for message address > > src/lib-mail/message-address.c | 99 +++++++++++++++++++++++++++++++---- > src/lib-mail/test-message-address.c | 11 +++- > 2 files changed, 98 insertions(+), 12 deletions(-) >Again "Undelivered Mail Returned to Sender" :-( Cannot send them... -- Pali Roh?r pali.rohar at gmail.com
aki.tuomi at dovecot.fi
2016-Apr-04 17:31 UTC
[PATCH 0/7] Fixes for lib-mail message-address
> On April 4, 2016 at 8:18 PM Pali Roh?r <pali.rohar at gmail.com> wrote: > > > On Monday 04 April 2016 19:12:56 Pali Roh?r wrote: > > Hello, > > > > I borrowed dovecot parser for email addresses and going to use it in new > > perl module as replacement for Email::Address. During implementation and > > testing I found bugs in dovecot parser & generator. So I'm sending my > > patches together with tests. > > > > Pali Roh?r (7): > > lib-mail: message_address_write: Fix generating empty group list > > lib-mail: message_address_write: Fix generating group list with empty > > name > > lib-mail: parse_addr_spec: Like in rfc822_skip_comment() check if > > last_comment is not NULL > > lib-mail: parse_addr_spec: Email address without local-part is > > invalid > > lib-mail: parse_mailbox: Set display name instead mailbox when > > parsing failed > > lib-mail: message_address_write: Quote and escape strings if needed > > lib-mail: Update tests for message address > > > > src/lib-mail/message-address.c | 99 > > +++++++++++++++++++++++++++++++---- > > src/lib-mail/test-message-address.c | 11 +++- > > 2 files changed, 98 insertions(+), 12 deletions(-) > > > > Again "Undelivered Mail Returned to Sender" :-( Cannot send them... > > -- > Pali Roh?r > pali.rohar at gmail.comCan you please send them directly to me, please? --- Aki Tuomi