dovecot - Mar 2009 - 1.2.beta4: Fatal: io_loop_handle_add: epoll_ctl(1, 11): Bad file descriptor

Whenever dovecot is stopped while a dict process is running I see

  Fatal: io_loop_handle_add: epoll_ctl(1, 11): Bad file descriptor

in the error log.

The following patch fixes this for me. I'm sure there is a better way
though.




--- dovecot-1.2.beta4/src/master/dict-process.c.orig	2009-03-27
16:44:59.000000000 +0100
+++ dovecot-1.2.beta4/src/master/dict-process.c	2009-03-27 18:59:24.000000000
+0100
@@ -209,11 +209,6 @@ dict_process_destroyed(struct child_proc
 	struct dict_listener *listener = process->listener;

 	dict_process_deinit(process);
-	if (listener->processes == NULL) {
-		/* last listener died, create new ones */
-		listener->io = io_add(listener->fd, IO_READ,
-				      dict_listener_input, listener);
-	}
 }

 void dict_processes_init(void)

On Fri, 2009-03-27 at 19:17 +0100, e-frog wrote:
> Whenever dovecot is stopped while a dict process is running I see
> 
>   Fatal: io_loop_handle_add: epoll_ctl(1, 11): Bad file descriptor
I think this also fixes it:
http://hg.dovecot.org/dovecot-1.2/rev/7ddf32656d8c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20090401/3417dbe6/attachment-0002.bin>

> I think this also fixes it:
> http://hg.dovecot.org/dovecot-1.2/rev/7ddf32656d8c
Yes, that fixes it. Thanks Timo!