dovecot - Apr 2007 - [PATCH] to fix 2 pam issues

Timo,

	I finally made the time to backport a pam fix I created for proftpd over
to dovecot, that allows FreeBSD's pam_group to work as expected.  (the bug
was
escalated to me internally hehe.. ).

I also noticed an issue while testing that will be confusing to users. If the
docs stay as is, or the other half of this patch is applied, then when the
dovecot.conf contains:

passdb pam {
     args = *
}

the imap files within etc/pam.d right now have to be named 'IMAP' and
'POP3' rather than the expected 'imap' and 'pop3'.  The
attached patch fixes
the code to match the docs.


	-Phil.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-passdb-pam.c
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20070402/4e9ef7a6/attachment.c>

On Mon, 2007-04-02 at 16:42 -0600, Phil Oleson wrote:
> Timo,
> 
> 	I finally made the time to backport a pam fix I created for proftpd over
> to dovecot, that allows FreeBSD's pam_group to work as expected.  (the
bug was
> escalated to me internally hehe.. ).
I added this to CVS HEAD, but I don't think I'll add it for v1.0. Maybe
for v1.0.1.
> I also noticed an issue while testing that will be confusing to users. If
the
> docs stay as is, or the other half of this patch is applied, then when the
> dovecot.conf contains:
> 
> passdb pam {
>      args = *
> }
> 
> the imap files within etc/pam.d right now have to be named 'IMAP'
and
> 'POP3' rather than the expected 'imap' and 'pop3'. 
The attached patch fixes
> the code to match the docs.
Linux PAM actually lowercases them internally, so I hadn't noticed. If I
change this it could break some existing installations.. But I guess
it's better to do it now than have it confusingly work in different
ways. Changed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20070403/84113a75/attachment.bin>