compiz - Jun 2007 - [PATCH] Add option to Move for disabling server position sync on each notify

The new move plugin interface that makes the applications sync to
Xserver position at each move notify, also if it could be considered
important, caused - as negative point - a poor wobbly quality while
moving windows...
That's why some kinds of "forks" were made to disable this new
feature
(see the "bouge" plugin), so I decided, instead of use
"another" plugin
simply to patch the git move plugins to add an option that will allow
users to decide which move type should be used.

So pratically, I've looked what has been really changed in commit [1]
(the one in which David applied the new sync-move), and pratically I
edited it until I got all working in both the ways. To made this
selectable by users I've added an "compare_server_motion" option,
that
is enabled in the xml file by default (so without user interaction, all
works like before).

Look at the diff, and let me know! :)

Trevi?o

[1] commit: 2d381e9f879610f4c02b6cf0ce1ac3ffbd3ed218

-- 
Trevi?o's Blog - Life and Linux
http://3v1n0.tuxfamily.org/blog/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: compiz-move-compare-to-server-motion-notify-option.patch
Type: text/x-patch
Size: 2692 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/compiz/attachments/20070625/239c6beb/attachment.bin

Le Monday 25 June 2007 03:26:06 Trevi?o, vous avez
?crit?:
> The new move plugin interface that makes the applications sync to
> Xserver position at each move notify, also if it could be considered
> important, caused - as negative point - a poor wobbly quality while
> moving windows...
> That's why some kinds of "forks" were made to disable this
new feature
> (see the "bouge" plugin), so I decided, instead of use
"another" plugin
> simply to patch the git move plugins to add an option that will allow
> users to decide which move type should be used.
>
> So pratically, I've looked what has been really changed in commit [1]
> (the one in which David applied the new sync-move), and pratically I
> edited it until I got all working in both the ways. To made this
> selectable by users I've added an "compare_server_motion"
option, that
> is enabled in the xml file by default (so without user interaction, all
> works like before).
>
> Look at the diff, and let me know! :)
>
> Trevi?o
>
> [1] commit: 2d381e9f879610f4c02b6cf0ce1ac3ffbd3ed218
Hello, i'm the one who "fork" move plugin...

I use move plugin on my two nvidia cards (no problem anymore, don't know
why)
and the bouge plugin with my intel card.

I think David is wrong when he think performance depend on applications... 
Here i have 3 kde 3.5.7 desktops running debian and only the intel one have 
bad performance with move plugin (near 90 % of cpu...).

Cedric

On Mon, 2007-06-25 at 03:26 +0200, Trevi?o wrote: 
> The new move plugin interface that makes the applications sync to
> Xserver position at each move notify, also if it could be considered
> important, caused - as negative point - a poor wobbly quality while
> moving windows...
> That's why some kinds of "forks" were made to disable this
new feature
> (see the "bouge" plugin), so I decided, instead of use
"another" plugin
> simply to patch the git move plugins to add an option that will allow
> users to decide which move type should be used.
> 
> So pratically, I've looked what has been really changed in commit [1]
> (the one in which David applied the new sync-move), and pratically I
> edited it until I got all working in both the ways. To made this
> selectable by users I've added an "compare_server_motion"
option, that
> is enabled in the xml file by default (so without user interaction, all
> works like before).
> 
> Look at the diff, and let me know! :)
OK, just to give a little update on the situation with the move plugin.

Not actually changing the server side position when moving a window is a
very useful feature and something that the move plugin should definitely
support.

However, the way that's been done previously, by modifying w->attrib.x
and w->attrib.y is very bad. It should instead be done by modifying the
CompTransform when painting the window but the reason I haven't
implemented this yet is that the wobbly functionality is not going to
work with this until the new animation framework is in place. So here's
the steps that need to be made before this movement mode will be
supported:

1. Add animation framework
2. Update wobbly plugin to use new animation framework
3. Update move plugin to use new animation framework

-David