Danny Baumann
2007-Jun-20 12:53 UTC
[compiz] [PATCH] Case insensitive matching for the regex plugin
Hi, I have created an addition to the regex plugin that allows case insensitive matching for title/class/name/role. To enable the case insentive matching, I chose to prepend an 'i' before the tag (ititle=, iclass=, ...). The patch is obviously attached ;-) Are there any objections against putting this code in? Regards, Danny -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Added-case-insensitive-matching.patch Type: application/mbox Size: 0 bytes Desc: not available Url : http://lists.freedesktop.org/archives/compiz/attachments/20070620/5a504a8a/attachment.bin
Mike Dransfield
2007-Jun-21 13:03 UTC
[compiz] [PATCH] Case insensitive matching for the regex plugin
Danny Baumann wrote:> Hi, > > I have created an addition to the regex plugin that allows case > insensitive matching for title/class/name/role. To enable the case > insentive matching, I chose to prepend an 'i' before the tag (ititle=, > iclass=, ...). The patch is obviously attached ;-) > > Are there any objections against putting this code in? >No objections as such, but maybe it would be better to make the regex plugin be case-insensitive by default and if necessary, add an option to be case-sensitive. I cannot think of any real-world cases where the average user would want case-sensitive. In fact it leads to a lot of support issues when matching by class. Regards Mike> Regards, > > Danny > > ------------------------------------------------------------------------ > > _______________________________________________ > compiz mailing list > compiz at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/compiz >
David Reveman
2007-Jul-11 22:55 UTC
[compiz] [PATCH] Case insensitive matching for the regex plugin
On Wed, 2007-06-20 at 14:53 +0200, Danny Baumann wrote:> Hi, > > I have created an addition to the regex plugin that allows case > insensitive matching for title/class/name/role. To enable the case > insentive matching, I chose to prepend an 'i' before the tag (ititle=, > iclass=, ...). The patch is obviously attached ;-) > > Are there any objections against putting this code in?No, but instead of adding a second set of tags maybe we should allow the expressions to end with "/i" for case insensitive matching like perl. I'm ok with either solution and not really sure which one I actually prefer. -David