Hi, I had a look at some problems I saw in the Water plugin. Here are the patches fixing those. The file names should be self-descriptive. Regards, Erkin -------------- next part --------------
On Sun, 2007-05-13 at 18:03 -0500, Erkin Bahceci wrote:> Hi, > > I had a look at some problems I saw in the Water plugin. Here are the > patches fixing those. > > The file names should be self-descriptive.Great, I've committed all patches except Stop-Water-drawing-right-after-waves-disappear as I'm not sure how you came to the conclusion that the count variable could be decremented at that rate. Did you make any calculations to come up with that or is it just based on testing on your machine? - David
On 5/14/07, David Reveman <davidr at novell.com> wrote:> Great, I've committed all patches except > Stop-Water-drawing-right-after-waves-disappear as I'm not sure how you > came to the conclusion that the count variable could be decremented at > that rate. Did you make any calculations to come up with that or is it > just based on testing on your machine?Just by testing a few values. Since the decrement is happening where the water update takes place (both independent of msSinceLastPaint), it should work on any machine. Is it not the case? Regards, Erkin