compiz - Nov 2007 - [PATCH] Fix fragment function leak.

Hi,

This patch fixes a leak when creating fragment functions in some of
the plugins. The leak happens when there is a plugin that uses a
fragment program with parameters and texture units on only a subset of
windows. During screen painting, the allocated param and unit change
across windows in the patched plugins, which (because of the mismatch
with the previously created and stored function) causes new fragment
functions to be created at each frame without destroying the old one,
increasing the length of s->fragmentFunctions and slowly degrading
painting performance.

Regards,
Erkin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-fragment-function-leak.patch
Type: text/x-patch
Size: 1932 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/compiz/attachments/20071104/e7b7d3ce/attachment.bin

Please disregard this patch. Apparently only the reflex plugin had the
problem I described and the patch wasn't doing what I meant to do for
water, blur, and video plugins. A fix is not necessary for those since
the problem was already handled there.

Regards,
Erkin

On 11/4/07, Erkin Bahceci <erkinbah at gmail.com>
wrote:
> Hi,
>
> This patch fixes a leak when creating fragment functions in some of
> the plugins. The leak happens when there is a plugin that uses a
> fragment program with parameters and texture units on only a subset of
> windows. During screen painting, the allocated param and unit change
> across windows in the patched plugins, which (because of the mismatch
> with the previously created and stored function) causes new fragment
> functions to be created at each frame without destroying the old one,
> increasing the length of s->fragmentFunctions and slowly degrading
> painting performance.
>
> Regards,
> Erkin
>
>

-- 
- Erkin