On 11/16/2015 01:39 PM, Nick Bright wrote:> This is very frustrating, and not obvious. If --permanent doesn't work > for a command, then it should give an error - not silently fail > without doing anything!But --permanent *did* work. What you're seeing is the documented behavior: --permanent The permanent option --permanent can be used to set options permanently. These changes are not effective immediately, only after service restart/reload or system reboot. Without the --permanent option, a change will only be part of the runtime configuration. If you want to make a change in runtime and permanent configuration, use the same call with and without the --permanent option.
On 16.11.2015 22:58, Gordon Messmer wrote:> On 11/16/2015 01:39 PM, Nick Bright wrote: >> This is very frustrating, and not obvious. If --permanent doesn't work >> for a command, then it should give an error - not silently fail >> without doing anything! > > But --permanent *did* work. > > What you're seeing is the documented behavior: > --permanent > The permanent option --permanent can be used to set options > permanently. These changes are not effective immediately, only > after service restart/reload or system reboot. Without the > --permanent option, a change will only be part of the runtime > configuration. > > If you want to make a change in runtime and permanent > configuration, use the same call with and without the > --permanent > option.That's fairly annoying behavior as it creates the potential for accidentally diverging configurations. Why not do the same as virsh an have two options for this? When I attach a device I can specify --config to update the persistent configuration, --live to update the runtime configuration and both if I want to change both. That's a much better API in my opinion. Regards, Dennis
Em 17-11-2015 01:26, Dennis Jacobfeuerborn escreveu:> On 16.11.2015 22:58, Gordon Messmer wrote: >> On 11/16/2015 01:39 PM, Nick Bright wrote: >>> This is very frustrating, and not obvious. If --permanent doesn't work >>> for a command, then it should give an error - not silently fail >>> without doing anything! >> >> But --permanent *did* work. >> >> What you're seeing is the documented behavior: >> --permanent >> The permanent option --permanent can be used to set options >> permanently. These changes are not effective immediately, only >> after service restart/reload or system reboot. Without the >> --permanent option, a change will only be part of the runtime >> configuration. >> >> If you want to make a change in runtime and permanent >> configuration, use the same call with and without the >> --permanent >> option. > > That's fairly annoying behavior as it creates the potential for > accidentally diverging configurations. > Why not do the same as virsh an have two options for this? When I attach > a device I can specify --config to update the persistent configuration, > --live to update the runtime configuration and both if I want to change > both. That's a much better API in my opinion.It's the same thing but with different names and a default, --config. And I agree, it would be nice to be able to issue both options at once. Would you open a BZ asking for this or should I? Marcelo
On 11/16/2015 3:58 PM, Gordon Messmer wrote:> On 11/16/2015 01:39 PM, Nick Bright wrote: >> This is very frustrating, and not obvious. If --permanent doesn't >> work for a command, then it should give an error - not silently fail >> without doing anything! > > But --permanent *did* work.No, it didn't. Not for changing the zone. After using --permanent, and restarting the firewall, _the zone was not changed_. I've duplicated this behavior on a half dozen installs now. -- ----------------------------------------------- - Nick Bright - - Vice President of Technology - - Valnet -=- We Connect You -=- - - Tel 888-332-1616 x 315 / Fax 620-331-0789 - - Web http://www.valnet.net/ - ----------------------------------------------- - Are your files safe? - - Valnet Vault - Secure Cloud Backup - - More information & 30 day free trial at - - http://www.valnet.net/services/valnet-vault - ----------------------------------------------- This email message and any attachments are intended solely for the use of the addressees hereof. This message and any attachments may contain information that is confidential, privileged and exempt from disclosure under applicable law. If you are not the intended recipient of this message, you are prohibited from reading, disclosing, reproducing, distributing, disseminating or otherwise using this transmission. If you have received this message in error, please promptly notify the sender by reply E-mail and immediately delete this message from your system.