Xen devel - Jul 2010 - [PATCH] remove Default-Enabled from LSB header

Default-Enabled: is not a LSB keyword.
Move it out of the LSB section to avoid an openSuSE buildcheck warning.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

---

It may be removed altogether, even google has no hits besides the old Debian bug
#458502

 tools/hotplug/Linux/init.d/xencommons |    2 +-
 tools/hotplug/Linux/init.d/xend       |    2 +-
 tools/hotplug/Linux/init.d/xendomains |    2 +-
 tools/xenballoon/xenballoond.init     |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

--- xen-unstable.hg-4.1.21836.orig/tools/hotplug/Linux/init.d/xencommons
+++ xen-unstable.hg-4.1.21836/tools/hotplug/Linux/init.d/xencommons
@@ -14,10 +14,10 @@
 # Should-Stop:
 # Default-Start:     3 4 5
 # Default-Stop:      1
-# Default-Enabled:   yes
 # Short-Description: Start/stop xenstored and xenconsoled
 # Description:       Starts and stops the daemons neeeded for xl/xend
 ### END INIT INFO
+# Default-Enabled:   yes
 
 test -f /etc/sysconfig/xencommons && . /etc/sysconfig/xencommons
 
--- xen-unstable.hg-4.1.21836.orig/tools/hotplug/Linux/init.d/xend
+++ xen-unstable.hg-4.1.21836/tools/hotplug/Linux/init.d/xend
@@ -14,10 +14,10 @@
 # Should-Stop:
 # Default-Start:     3 4 5
 # Default-Stop:      0 1 2 6
-# Default-Enabled:   yes
 # Short-Description: Start/stop xend
 # Description:       Starts and stops the Xen control daemon.
 ### END INIT INFO
+# Default-Enabled:   yes
 
 shopt -s extglob
 
--- xen-unstable.hg-4.1.21836.orig/tools/hotplug/Linux/init.d/xendomains
+++ xen-unstable.hg-4.1.21836/tools/hotplug/Linux/init.d/xendomains
@@ -22,11 +22,11 @@
 # Should-Stop:
 # Default-Start:     3 4 5
 # Default-Stop:      0 1 2 6
-# Default-Enabled:   yes
 # Short-Description: Start/stop secondary xen domains
 # Description:       Start / stop domains automatically when domain 0 
 #                    boots / shuts down.
 ### END INIT INFO
+# Default-Enabled:   yes
 
 CMD=xm
 $CMD list &> /dev/null
--- xen-unstable.hg-4.1.21836.orig/tools/xenballoon/xenballoond.init
+++ xen-unstable.hg-4.1.21836/tools/xenballoon/xenballoond.init
@@ -16,10 +16,10 @@
 # Should-Stop:
 # Default-Start:     3 4 5
 # Default-Stop:      0 1 2 6
-# Default-Enabled:   yes
 # Short-Description: Start/stop xend
 # Description:       Starts and stops the Xen ballooning daemon.
 ### END INIT INFO
+# Default-Enabled:   yes
 
 # Source function library
 . /etc/init.d/functions

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Olaf Hering writes ("[Xen-devel] [PATCH] remove Default-Enabled from LSB
header"):
> Default-Enabled: is not a LSB keyword.
> Move it out of the LSB section to avoid an openSuSE buildcheck warning.
I''m pretty sure it was put there for a reason by the people who added
these files.  If we move it out of the INIT INFO section it''s probably
going to stop working.

Is it actually a breach of the LSB spec to include nonstandard
keywords ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Jul 23, Ian Jackson wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH] remove Default-Enabled from
LSB header"):
> > Default-Enabled: is not a LSB keyword.
> > Move it out of the LSB section to avoid an openSuSE buildcheck
warning.
> 
> I''m pretty sure it was put there for a reason by the people who
added
> these files.  If we move it out of the INIT INFO section it''s
probably
> going to stop working.
Its not clear what the intention was, LSB does not mention this keyword.
Google has some hits about X-UnitedLinux-Default-Enabled: which implies
what someone tried to get rid of the vendor part from this old string
from end of 2002.
I''m sure nothing will break if the lines disappear.
> Is it actually a breach of the LSB spec to include nonstandard
> keywords ?
I havent checked if LSB forbids it. Most likely the tools should
tolerate unknown keywords.

Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Olaf Hering writes ("Re: [Xen-devel] [PATCH] remove Default-Enabled from
LSB header"):
> Its not clear what the intention was, LSB does not mention this keyword.
> Google has some hits about X-UnitedLinux-Default-Enabled: which implies
> what someone tried to get rid of the vendor part from this old string
> from end of 2002.
Thanks for investigating.
> I''m sure nothing will break if the lines disappear.
OK, right, I''ll apply your patch.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel