Olaf Hering
2010-Jul-23 12:21 UTC
[Xen-devel] [PATCH] correct xend initscript dependency in LSB part
Add missing dependencies to runlevel script xend requires at least xenstored Signed-off-by: Olaf Hering <olaf@aepfle.de> --- xen-unstable.hg-4.1.21836.orig/tools/hotplug/Linux/init.d/xend +++ xen-unstable.hg-4.1.21836/tools/hotplug/Linux/init.d/xend @@ -8,9 +8,9 @@ # description: Starts and stops the Xen control daemon. ### BEGIN INIT INFO # Provides: xend -# Required-Start: $syslog $remote_fs +# Required-Start: $syslog $remote_fs xenstored # Should-Start: -# Required-Stop: $syslog $remote_fs +# Required-Stop: $syslog $remote_fs xenstored # Should-Stop: # Default-Start: 3 4 5 # Default-Stop: 0 1 2 6 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Conny Seidel
2010-Jul-30 14:01 UTC
Re: [Xen-devel] [PATCH] correct xend initscript dependency in LSB part
Hi, On Fri, 23 Jul 2010 08:21:20 -0400 Olaf Hering <olaf@aepfle.de> wrote:>Add missing dependencies to runlevel script >xend requires at least xenstoredThis change only makes sense, if there is a /etc/init.d/xenstored init-script, which I wasn''t able to find in the sources. It would be useful to change this to xencommons, which is mentioned when running the xend-script manual. # /etc/init.d/xend start xencommons should be started first. # /etc/init.d/xencommons start Starting xenstored... Setting domain 0 name... Starting xenconsoled... # /etc/init.d/xend start # regards, Conny Seidel ## ################################################################## # Email : conny.seidel@amd.com GnuPG-Key : 0xA6AB055D # # Fingerprint: 17C4 5DB2 7C4C C1C7 1452 8148 F139 7C09 A6AB 055D # ################################################################## # Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach # # General Managers: Alberto Bozzo, Andrew Bowd # # Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen # # HRB Nr. 43632 # ################################################################## _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2010-Jul-30 14:11 UTC
Re: [Xen-devel] [PATCH] correct xend initscript dependency in LSB part
Conny Seidel writes ("Re: [Xen-devel] [PATCH] correct xend initscript
dependency in LSB part"):> This change only makes sense, if there is a /etc/init.d/xenstored
> init-script, which I wasn''t able to find in the sources.
As I understand it, Required-Start names services which are listed in
the Provides of another init script, not the other script name directly.
Is that not true ? Perhaps you''d like to give chapter and verse from
the LSB spec.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Olaf Hering
2010-Jul-30 15:28 UTC
Re: [Xen-devel] [PATCH] correct xend initscript dependency in LSB part
On Fri, Jul 30, Conny Seidel wrote:> Hi, > > On Fri, 23 Jul 2010 08:21:20 -0400 > Olaf Hering <olaf@aepfle.de> wrote: > > >Add missing dependencies to runlevel script > >xend requires at least xenstored > > This change only makes sense, if there is a /etc/init.d/xenstored > init-script, which I wasn''t able to find in the sources.The Required/Should-Start lines reference Provides lines in other runlevel scripts, so that tools which actually create the runlevel links and their numbers can get the ordering right. Do you see any issues with my change? Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Olaf Hering
2010-Jul-30 15:33 UTC
Re: [Xen-devel] [PATCH] correct xend initscript dependency in LSB part
On Fri, Jul 30, Conny Seidel wrote:> On Fri, 30 Jul 2010 10:11:01 -0400 > Ian Jackson <Ian.Jackson@eu.citrix.com> wrote: > > >As I understand it, Required-Start names services which are listed in > >the Provides of another init script, not the other script name directly. > >Is that not true ? Perhaps you''d like to give chapter and verse from > >the LSB spec. > > >Ian. > > Ouch, you are right on the LSB conformity. Sorry my bad. > > But if I get an error message like this: > # chkconfig xend on > insserv: Service xenstored has to be enabled for service xend > insserv: exiting now! > /sbin/insserv failed, exit code 1 > > I would assume that I need to start /etc/init.d/xenstored.insserv does not automatically enable all dependencies. An ''insserv xencommons'' is required first. Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Conny Seidel
2010-Jul-30 15:38 UTC
Re: [Xen-devel] [PATCH] correct xend initscript dependency in LSB part
On Fri, 30 Jul 2010 10:11:01 -0400 Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:>As I understand it, Required-Start names services which are listed in >the Provides of another init script, not the other script name directly. >Is that not true ? Perhaps you''d like to give chapter and verse from >the LSB spec.>Ian.Ouch, you are right on the LSB conformity. Sorry my bad. But if I get an error message like this: # chkconfig xend on insserv: Service xenstored has to be enabled for service xend insserv: exiting now! /sbin/insserv failed, exit code 1 I would assume that I need to start /etc/init.d/xenstored. Conny ## ################################################################## # Email : conny.seidel@amd.com GnuPG-Key : 0xA6AB055D # # Fingerprint: 17C4 5DB2 7C4C C1C7 1452 8148 F139 7C09 A6AB 055D # ################################################################## # Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach # # General Managers: Alberto Bozzo, Andrew Bowd # # Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen # # HRB Nr. 43632 # ################################################################## _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2010-Jul-30 15:43 UTC
Re: [Xen-devel] [PATCH] correct xend initscript dependency in LSB part
Conny Seidel writes ("Re: [Xen-devel] [PATCH] correct xend initscript
dependency in LSB part"):> Ouch, you are right on the LSB conformity. Sorry my bad.
>
> But if I get an error message like this:
> # chkconfig xend on
> insserv: Service xenstored has to be enabled for service xend
> insserv: exiting now!
> /sbin/insserv failed, exit code 1
>
> I would assume that I need to start /etc/init.d/xenstored.
I don''t see what we can do about this. The xencommons script does
more than xenstored - hence the name. We can''t change the Requires to
refer to xencommons because it won''t work.
I think you need to take the unhelpfulness of the error message up
with the maintainers of insserv.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel