Xen devel - Nov 2009 - [PATCH] Fix compile error when CONFIG_XEN_PCIDEV_FRONTEND=m

These errors show up when that is defined:
xen-pcifront.c:261: error: redefinition of
''pci_frontend_enable_msix''
xen/pci.h:53: error: previous definition of
''pci_frontend_enable_msix'' was here
xen-pcifront.c:310: error: redefinition of
''pci_frontend_disable_msix''
pci.h:56: error: previous definition of
''pci_frontend_disable_msix'' was here
xen-pcifront.c:330: error: redefinition of
''pci_frontend_enable_msi''
pci.h:47: error: previous definition of
''pci_frontend_enable_msi'' was here
xen-pcifront.c:354: error: redefinition of
''pci_frontend_disable_msi''
pci.h:50: error: previous definition of
''pci_frontend_disable_msi'' was here
---
 drivers/pci/Kconfig |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index 3a858a8..4a658b1 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -52,11 +52,10 @@ config PCI_STUB
 	  When in doubt, say N.
 
 config XEN_PCIDEV_FRONTEND
-        tristate "Xen PCI Frontend"
+        bool "Xen PCI Frontend"
         depends on XEN && PCI && X86_64
         select HOTPLUG
 	select XEN_XENBUS_FRONTEND
-	default y
         help
           The PCI device frontend driver allows the kernel to import arbitrary
           PCI devices from a PCI backend to support PCI driver domains.
-- 
1.6.2.5


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, 18 Nov 2009, Konrad Rzeszutek Wilk wrote:
>
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 3a858a8..4a658b1 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -52,11 +52,10 @@ config PCI_STUB
> 	  When in doubt, say N.
>
> config XEN_PCIDEV_FRONTEND
> -        tristate "Xen PCI Frontend"
> +        bool "Xen PCI Frontend"
>         depends on XEN && PCI && X86_64
>         select HOTPLUG
> 	select XEN_XENBUS_FRONTEND
> -	default y
>         help
>           The PCI device frontend driver allows the kernel to import
arbitrary
>           PCI devices from a PCI backend to support PCI driver domains.
This doesn''t really fix the problem, it just avoids it. I think it
would
be better to isolate the cause and adjust things so it is possible for 
this to be built as a module.

 	Michael Young

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel