Tobias Gruetzmacher
2006-May-03 11:47 UTC
[Xen-devel] [PATCH] Fix bashism in Linux kernel makefile
Hi,
this is a simple patch to remove some bashism from the Makefile.xen for
all those who are as pedantic as myself and install some simpler
POSIX-compliant shell as /bin/sh.
The Changeset is against xen-3.0-testing.hg, but the patch should also
apply to xen-unstable.hg.
Greetings Tobi
# HG changeset patch
# User tobias@portfolio16.de
# Node ID fc9ac1720a562bd2f3307a278ddcf660d5a32adb
# Parent c6fee5f7c83834fab2409975fc383643a3c3787d
Fix bashism in Linux kernel makefile
diff -r c6fee5f7c838 -r fc9ac1720a56 linux-2.6-xen-sparse/scripts/Makefile.xen
--- a/linux-2.6-xen-sparse/scripts/Makefile.xen Tue May 02 17:24:29 2006 +0100
+++ b/linux-2.6-xen-sparse/scripts/Makefile.xen Wed May 03 13:04:48 2006 +0200
@@ -2,9 +2,9 @@
# cherrypickxen($1 = allobj)
cherrypickxen = $(foreach var, $(1), \
$(shell o=$(var); \
- c=$${o/%.o/-xen.c}; \
- s=$${o/%.o/-xen.S}; \
- oxen=$${o/%.o/-xen.o}; \
+ c=$(var:.o=-xen.c); \
+ s=$(var:.o=-xen.S); \
+ oxen=$(var:.o=-xen.o); \
[ -f $(srctree)/$(src)/$${c} ] || \
[ -f $(srctree)/$(src)/$${s} ] \
&& echo $$oxen \
--
GPG-Key 0xE2BEA341 - signed/encrypted mail preferred
My, oh so small, homepage: http://portfolio16.de/
http://www.fli4l.de/ - ISDN- & DSL-Router on one disk!
Registered FLI4L-User #00000003
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Keir Fraser
2006-May-05 12:55 UTC
Re: [Xen-devel] [PATCH] Fix bashism in Linux kernel makefile
On 3 May 2006, at 12:47, Tobias Gruetzmacher wrote:> this is a simple patch to remove some bashism from the Makefile.xen for > all those who are as pedantic as myself and install some simpler > POSIX-compliant shell as /bin/sh. > > The Changeset is against xen-3.0-testing.hg, but the patch should also > apply to xen-unstable.hg.You got beaten to the punch by Herbert Xu. His patch changes the same three lines but in a different way. Hopefully his patch is satisfactory for you and renders your patch redundant. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel