Li, Chengyuan
2005-Sep-20 09:17 UTC
RE: [Xen-devel] [PATCH][VT] Patch to allow VMXdomainsto be destroyedor shut down cleanly
Keir Fraser scribbled on 2005年9月20日 17:09:> On 20 Sep 2005, at 09:51, Jiang, Yunhong wrote: > >> Hi, Keir >> Do you mean a patch like this? > > Something like that. Should get_page/put_page in the code that deals > with cr3 updates also be gated on paging_enabled?get_page/put_page has already been handled when cr3 updates, hasn''t it?> > -- Keir > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-develThanks, Chengyuan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Sep-20 09:24 UTC
Re: [Xen-devel] [PATCH][VT] Patch to allow VMXdomainsto be destroyedor shut down cleanly
On 20 Sep 2005, at 10:17, Li, Chengyuan wrote:> > get_page/put_page has already been handled when cr3 updates, hasn''t it?But it happens unconditionally doesn''t it? What if the guest writes cr3 while paging is disabled, then enables paging in cr0? Won''t that cause us to get_page() twice? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel