Li, Chengyuan
2005-Sep-20 09:24 UTC
RE: [Xen-devel] [PATCH][VT] Patch to allowVMXdomainsto be destroyedor shut down cleanly
Keir Fraser scribbled on 2005年9月20日 17:24:> On 20 Sep 2005, at 10:17, Li, Chengyuan wrote: > >> >> get_page/put_page has already been handled when cr3 updates, hasn''t >> it? > > But it happens unconditionally doesn''t it? What if the guest writes > cr3 while paging is disabled, then enables paging in cr0? Won''t that > cause us to get_page() twice?No, in cr3 handler, it only get_page/put_page when paging enabled. If paging is disabled, no get_page/put_page operations.> > -- Keir > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-develThanks, Chengyuan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Sep-20 09:41 UTC
Re: [Xen-devel] [PATCH][VT] Patch to allowVMXdomainsto be destroyedor shut down cleanly
On 20 Sep 2005, at 10:24, Li, Chengyuan wrote:> No, in cr3 handler, it only get_page/put_page when paging enabled. If > paging is disabled, no get_page/put_page operations.Ok, yep, I see that. Then I think your patch ought to work. If it''s tested then please send as an attachment (I can then easily extract and apply it). Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel