Ryan Harper
2005-Mar-22 22:15 UTC
[Xen-devel] [PATCH] 2.6.11-xen-sparse: missing CONFIG_SMP in pgtable-2level
The latest (20050322) xen-unstable fails to boot dom0 when CONFIG_SMP is enabled. The last working snapshot was from 2005-03-18. I traced the problem to a dropped #ifdef CONFIG_SMP in pgtable-2level.h I''ve attached a debug trace of dom0 dying without the patch applied. Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com diffstat output: pgtable-2level.h | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletion(-) Signed-off-by: Ryan Harper <ryanh@us.ibm.com> --- --- a/linux-2.6.11-xen-sparse/include/asm-xen/asm-i386/pgtable-2level.h 2005-03-21 22:39:28.000000000 -0600 +++ b/linux-2.6.11-xen-sparse/include/asm-xen/asm-i386/pgtable-2level.h 2005-03-22 15:55:40.000000000 -0600 @@ -13,8 +13,13 @@ * within a page table are directly modified. Thus, the following * hook is made available. */ +#ifdef CONFIG_SMP +#define set_pte(pteptr, pteval) xen_l1_entry_update(pteptr, (pteval).pte_low) +#else #define set_pte(pteptr, pteval) (*(pteptr) = pteval) -#define set_pte_atomic(pteptr, pteval) set_pte(pteptr,pteval) +#endif + +#define set_pte_atomic(pteptr, pteval) set_pte(pteptr, pteval) #define set_pmd(pmdptr, pmdval) xen_l2_entry_update((pmdptr), (pmdval)) #define set_pte_batched(pteptr, pteval) \ queue_l1_entry_update(pteptr, (pteval).pte_low)
Jon Mason
2005-Mar-23 01:24 UTC
[Xen-devel] Re: [PATCH] 2.6.11-xen-sparse: missing CONFIG_SMP in pgtable-2level
I was experiencing a similar boot crash on my p4 HT enabled kernel, and the patch below fixed my problem. Good job Ryan! Thanks, Jon On Tuesday 22 March 2005 04:15 pm, Ryan Harper wrote:> The latest (20050322) xen-unstable fails to boot dom0 when CONFIG_SMP is > enabled. The last working snapshot was from 2005-03-18. I traced the > problem to a dropped #ifdef CONFIG_SMP in pgtable-2level.h > > I''ve attached a debug trace of dom0 dying without the patch applied. > > Ryan Harper > Software Engineer; Linux Technology Center > IBM Corp., Austin, Tx > (512) 838-9253 T/L: 678-9253 > ryanh@us.ibm.com > > diffstat output: > > pgtable-2level.h | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletion(-) > > Signed-off-by: Ryan Harper <ryanh@us.ibm.com> > --- > --- > a/linux-2.6.11-xen-sparse/include/asm-xen/asm-i386/pgtable-2level.h 2005-03 >-21 22:39:28.000000000 -0600 +++ > b/linux-2.6.11-xen-sparse/include/asm-xen/asm-i386/pgtable-2level.h 2005-03 >-22 15:55:40.000000000 -0600 @@ -13,8 +13,13 @@ > * within a page table are directly modified. Thus, the following > * hook is made available. > */ > +#ifdef CONFIG_SMP > +#define set_pte(pteptr, pteval) xen_l1_entry_update(pteptr, > (pteval).pte_low) +#else > #define set_pte(pteptr, pteval) (*(pteptr) = pteval) > -#define set_pte_atomic(pteptr, pteval) set_pte(pteptr,pteval) > +#endif > + > +#define set_pte_atomic(pteptr, pteval) set_pte(pteptr, pteval) > #define set_pmd(pmdptr, pmdval) xen_l2_entry_update((pmdptr), (pmdval)) > #define set_pte_batched(pteptr, pteval) \ > queue_l1_entry_update(pteptr, (pteval).pte_low)------------------------------------------------------- This SF.net email is sponsored by: 2005 Windows Mobile Application Contest Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones for the chance to win $25,000 and application distribution. Enter today at http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Ryan Harper
2005-Mar-24 15:50 UTC
Re: [Xen-devel] [PATCH] 2.6.11-xen-sparse: missing CONFIG_SMP in pgtable-2level
* Ryan Harper <ryanh@us.ibm.com> [2005-03-23 10:32]:> The latest (20050322) xen-unstable fails to boot dom0 when CONFIG_SMP is > enabled. The last working snapshot was from 2005-03-18. I traced the > problem to a dropped #ifdef CONFIG_SMP in pgtable-2level.hThis is still broken in 20050324. Any reason not to apply this patch? Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com ------------------------------------------------------- This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005 Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows Embedded(r) & Windows Mobile(tm) platforms, applications & content. Register by 3/29 & save $300 http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Keir Fraser
2005-Mar-24 21:48 UTC
Re: [Xen-devel] [PATCH] 2.6.11-xen-sparse: missing CONFIG_SMP in pgtable-2level
On 24 Mar 2005, at 15:50, Ryan Harper wrote:> * Ryan Harper <ryanh@us.ibm.com> [2005-03-23 10:32]: >> The latest (20050322) xen-unstable fails to boot dom0 when CONFIG_SMP >> is >> enabled. The last working snapshot was from 2005-03-18. I traced the >> problem to a dropped #ifdef CONFIG_SMP in pgtable-2level.h > > This is still broken in 20050324. Any reason not to apply this patch?It only fixed the symptom and not the root problem (broken TLB flushing in Xen). I''ve just checked in a proper fix. SMP domain0 is running okay for me now. -- Keir ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Ryan Harper
2005-Mar-24 21:59 UTC
Re: [Xen-devel] [PATCH] 2.6.11-xen-sparse: missing CONFIG_SMP in pgtable-2level
* Keir Fraser <Keir.Fraser@cl.cam.ac.uk> [2005-03-24 15:50]:> > On 24 Mar 2005, at 15:50, Ryan Harper wrote: > > >* Ryan Harper <ryanh@us.ibm.com> [2005-03-23 10:32]: > >>The latest (20050322) xen-unstable fails to boot dom0 when CONFIG_SMP > >>is > >>enabled. The last working snapshot was from 2005-03-18. I traced the > >>problem to a dropped #ifdef CONFIG_SMP in pgtable-2level.h > > > >This is still broken in 20050324. Any reason not to apply this patch? > > It only fixed the symptom and not the root problem (broken TLB flushing > in Xen). I''ve just checked in a proper fix. SMP domain0 is running okay > for me now.Sorry for the impatience. I''ll give it a test. Thanks. Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Ryan Harper
2005-Mar-24 23:17 UTC
Re: [Xen-devel] [PATCH] 2.6.11-xen-sparse: missing CONFIG_SMP in pgtable-2level
* Ryan Harper <ryanh@us.ibm.com> [2005-03-24 15:59]:> * Keir Fraser <Keir.Fraser@cl.cam.ac.uk> [2005-03-24 15:50]: > > > > On 24 Mar 2005, at 15:50, Ryan Harper wrote: > > > > >* Ryan Harper <ryanh@us.ibm.com> [2005-03-23 10:32]: > > >>The latest (20050322) xen-unstable fails to boot dom0 when CONFIG_SMP > > >>is > > >>enabled. The last working snapshot was from 2005-03-18. I traced the > > >>problem to a dropped #ifdef CONFIG_SMP in pgtable-2level.h > > > > > >This is still broken in 20050324. Any reason not to apply this patch? > > > > It only fixed the symptom and not the root problem (broken TLB flushing > > in Xen). I''ve just checked in a proper fix. SMP domain0 is running okay > > for me now. > > Sorry for the impatience. I''ll give it a test. Thanks.The patch works for me as well. Thanks Keir. Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel