Magenheimer, Dan (HP Labs Fort Collins)
2005-Mar-16 00:07 UTC
[Xen-devel] Recent -unstable changeset breaks xen/ia64 build
Changeset 1.1342 changes xen/include/xen/softirq.h to include xen/irq_cpustat.h. This breaks the xen/ia64 build. Why the change? asm-x86/hardirq.h already includes xen/irq_cpustat.h (as it does on linux and could/should on xen-ppc). Perhaps this was a "regression" to an older version as this was a problem that was fixed awhile ago. Removing the added include fixes the xen/ia64 build. Please reconsider this change. Thanks, Dan ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Keir Fraser
2005-Mar-16 08:14 UTC
[Xen-devel] Re: Recent -unstable changeset breaks xen/ia64 build
On 16 Mar 2005, at 00:07, Magenheimer, Dan (HP Labs Fort Collins) wrote:> Changeset 1.1342 changes xen/include/xen/softirq.h to > include xen/irq_cpustat.h. This breaks the xen/ia64 > build. > > Why the change? asm-x86/hardirq.h already includes > xen/irq_cpustat.h (as it does on linux and could/should > on xen-ppc). > > Perhaps this was a "regression" to an older version as > this was a problem that was fixed awhile ago. > > Removing the added include fixes the xen/ia64 build. > > Please reconsider this change.Okay I''ll drop that one and ppc can fix it up in their own headers. -- Keir ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel