Isaku Yamahata
2006-Apr-22 02:04 UTC
[Xen-devel] vm_normal_page() in linux-2.6-xen-sparse/mm/memory.c
vm_normal_page() @ linux-2.6-xen-sparse/mm/memory.c
...
if (!vma->vm_flags & VM_RESERVED)
print_bad_pte(vma, pte, addr);
note:VM_RESERVED=0x00080000
This if clause is always false.
Should it be "if (!(vma->vm_flags & VM_RESERVED))" ?
--
yamahata
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Keir Fraser
2006-Apr-22 08:46 UTC
Re: [Xen-devel] vm_normal_page() in linux-2.6-xen-sparse/mm/memory.c
On 22 Apr 2006, at 03:04, Isaku Yamahata wrote:> This if clause is always false. > Should it be "if (!(vma->vm_flags & VM_RESERVED))" ?Yes, now fixed. Thanks. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Seemingly Similar Threads
- [PATCH] xen/gntdev,gntalloc: Remove unneeded VM flags
- [PATCH] xen/gntdev: do not set VM_PFNMAP
- [PATCH] direct_remap_pfn_range vm_flags fix
- [PATCH] xen: gntdev: move use of GNTMAP_contains_pte next to the map_op
- [Patch RFC] nouveau accelerated on Xen pv-ops kernel