Isaku Yamahata
2006-Apr-10 08:36 UTC
[Xen-devel] [PATCH 4/6] grantable and address conversion patches
4/6 -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2006-Apr-10 10:24 UTC
Re: [Xen-devel] [PATCH 4/6] grantable and address conversion patches
I attached an updated patch following to the comment. -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Apr-10 10:36 UTC
Re: [Xen-devel] [PATCH 4/6] grantable and address conversion patches
On 10 Apr 2006, at 11:24, Isaku Yamahata wrote:> I attached an updated patch following to the comment.The macro has a poor name (which is forgivable, since the name of the field you''re filling in has a poor name which we''ll probably change). It''s also defined in (imo) the wrong place. I''d rather define a function to fill in the entire structure in gnttab.h. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2006-Apr-10 12:37 UTC
Re: [Xen-devel] [PATCH 4/6] grantable and address conversion patches
On Mon, Apr 10, 2006 at 11:36:34AM +0100, Keir Fraser wrote:> I''d rather define a function to fill in the entire structure in > gnttab.h.I hope that the attached patch is much more preferable than the previous one. I tested compilation and dom0 boot. -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Apr-10 12:47 UTC
Re: [Xen-devel] [PATCH 4/6] grantable and address conversion patches
On 10 Apr 2006, at 13:37, Isaku Yamahata wrote:>> I''d rather define a function to fill in the entire structure in >> gnttab.h. > > I hope that the attached patch is much more preferable > than the previous one. > I tested compilation and dom0 boot.Is the ''phys'' parameter to the new functions ever non-zero? Also, the call sites that pass a ptep pose a problem -- the host address should not be __pa()''ed as it''s already a machine (or pseudo-phys) address. On mapping you can check for GNTMAP_contains_pte. Perhaps we will need to pass flags to the unmap function too. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2006-Apr-12 13:23 UTC
Re: [Xen-devel] [PATCH 4/6] grantable and address conversion patches
I attached the updated patch. On Mon, Apr 10, 2006 at 01:47:20PM +0100, Keir Fraser wrote:> > On 10 Apr 2006, at 13:37, Isaku Yamahata wrote: > > >>I''d rather define a function to fill in the entire structure in > >>gnttab.h. > > > >I hope that the attached patch is much more preferable > >than the previous one. > >I tested compilation and dom0 boot. > > Is the ''phys'' parameter to the new functions ever non-zero? > > Also, the call sites that pass a ptep pose a problem -- the host > address should not be __pa()''ed as it''s already a machine (or > pseudo-phys) address. On mapping you can check for GNTMAP_contains_pte. > Perhaps we will need to pass flags to the unmap function too. > > -- Keir > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >-- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel