Sean Dague
2006-Mar-20 19:13 UTC
[Xen-devel] BROKEN BUILD (Re: Upgrade genapic code to 2.6.16-rc6 codebase. Remove entries from)
The following changeset breaks the build on gcc 4.0.1 with the following error: gcc -O2 -fomit-frame-pointer -DNDEBUG -m64 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -nostdinc -fno-builtin -fno-common -fno-strict-aliasing -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/home/sdague/xen-unstable/xen/include -I/home/sdague/xen-unstable/xen/include/asm-x86/mach-generic -I/home/sdague/xen-unstable/xen/include/asm-x86/mach-default -msoft-float -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchronous-unwind-tables -g -D__XEN__ -c es7000plat.c -o es7000plat.o cc1: warnings being treated as errors es7000plat.c: In function ''find_unisys_acpi_oem_table'': es7000plat.c:192: warning: ''sdt.count'' is used uninitialized in this function make[5]: *** [es7000plat.o] Error 1 Could we make compilation with gcc 4.x an entrance criteria for patches? -Sean On Mon, Mar 20, 2006 at 06:36:07PM +0000, Xen patchbot -unstable wrote:> Diffstat output: > > arch/x86/genapic/default.c | 18 +++++ > arch/x86/genapic/es7000.h | 14 +++- > arch/x86/genapic/es7000plat.c | 58 +++++++++-------- > include/asm-x86/genapic.h | 17 ----- > include/asm-x86/mach-bigsmp/mach_apic.h | 91 +++++++++------------------- > include/asm-x86/mach-bigsmp/mach_apicdef.h | 4 - > include/asm-x86/mach-default/mach_apic.h | 20 ------ > include/asm-x86/mach-default/mach_apicdef.h | 2 > include/asm-x86/mach-default/mach_ipi.h | 25 +++++++ > include/asm-x86/mach-default/mach_mpparse.h | 11 --- > include/asm-x86/mach-es7000/mach_apic.h | 20 ------ > include/asm-x86/mach-es7000/mach_apicdef.h | 2 > include/asm-x86/mach-es7000/mach_mpparse.h | 41 +++++++----- > include/asm-x86/mach-generic/mach_apic.h | 23 ++++++- > include/asm-x86/mach-generic/mach_apicdef.h | 1 > include/asm-x86/mach-generic/mach_mpparse.h | 12 ++- > include/asm-x86/mach-summit/mach_apic.h | 20 ------ > include/asm-x86/mach-summit/mach_apicdef.h | 2 > include/asm-x86/mach-summit/mach_mpparse.h | 11 --- > 19 files changed, 169 insertions(+), 223 deletions(-) > > # HG changeset patch > # User kaf24@firebug.cl.cam.ac.uk > # Node ID d982f5fa9bad263bf4b28afad2e55a5b1675faba > # Parent a8b1d4fad72d2b0bba1b121bc250b4ac80fcf9ac > Upgrade genapic code to 2.6.16-rc6 codebase. Remove entries from > genapic structure that Xen does not require (mostly because we do > not support Visual Workstation nor IBM/Sequent NUMA-Q). > > Signed-off-by: Keir Fraser <keir@xensource.com>-Sean -- Sean Dague IBM Linux Technology Center email: japh@us.ibm.com Open Hypervisor Team alt: sldague@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Mar-21 10:33 UTC
Re: [Xen-devel] BROKEN BUILD (Re: Upgrade genapic code to 2.6.16-rc6 codebase. Remove entries from)
On 20 Mar 2006, at 19:13, Sean Dague wrote:> Could we make compilation with gcc 4.x an entrance criteria for > patches?Turns out it''s a real bug, it''s also present in native Linux, and it isn''t picked up by gcc-4.1-pre on x86/64 on a debug build. Anyway, fixed now. :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel