Hi, all We clean up warning in xen/ia64 . We have cleaned up many warnings, but it remainded some warnings yet. These patches fix many issue (ex. panic dom0, oops domU/dom0...). we will fix compile warnnings one step at a time. For xen (common) - cleanup.include.xen.patch For xen (ia64) - cleanup.include.asm-ia64.patch - cleanup.linux.patch - cleanup.linux-xen.patch - cleanup.xen.patch Signed-off-by: Tsunehisa Doi <doi.tsunehisa@jp.fujitsu.com> Signed-off-by: Kouya SHIMURA <kouya@jp.fujitsu.com> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com> Best Regards, Akio Takebe, and Fujitsu team _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 27 Feb 2006, at 01:48, Akio Takebe wrote:> We clean up warning in xen/ia64 . > We have cleaned up many warnings, but it remainded some warnings yet. > > These patches fix many issue (ex. panic dom0, oops domU/dom0...). > we will fix compile warnnings one step at a time.I''ll assume these are destined for the ia64-unstable tree. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi, Keir>For xen (common) > - cleanup.include.xen.patchYes, this work is for Xen/ia64. This patch isn''t concerned with Xen/x86. But strlcpy() is in xen/common/string.c, so I think strlcpy() should be defined in xen/include/xen/string.h. Otherwise should strlcpy() be defined in xen/include/asm-ia64/linux/asm/ string.h? Best Regards, Akio Takebe> >On 27 Feb 2006, at 01:48, Akio Takebe wrote: > >> We clean up warning in xen/ia64 . >> We have cleaned up many warnings, but it remainded some warnings yet. >> >> These patches fix many issue (ex. panic dom0, oops domU/dom0...). >> we will fix compile warnnings one step at a time. > >I''ll assume these are destined for the ia64-unstable tree. > > -- Keir > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 27 Feb 2006, at 07:32, Akio Takebe wrote:> This patch isn''t concerned with Xen/x86. > But strlcpy() is in xen/common/string.c, > so I think strlcpy() should be defined in xen/include/xen/string.h. > Otherwise should strlcpy() be defined in > xen/include/asm-ia64/linux/asm/ > string.h?Okay, I''ll take that patch directly into xen-unstable. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alex Williamson
2006-Feb-27 16:44 UTC
[Xen-devel] Re: [Xen-ia64-devel] [Patch] cleanup warning in xen/ia64
On Mon, 2006-02-27 at 10:48 +0900, Akio Takebe wrote:> Hi, all > > We clean up warning in xen/ia64 . > We have cleaned up many warnings, but it remainded some warnings yet. > > These patches fix many issue (ex. panic dom0, oops domU/dom0...). > we will fix compile warnnings one step at a time. > > For xen (common) > - cleanup.include.xen.patch > > For xen (ia64) > - cleanup.include.asm-ia64.patch > - cleanup.linux.patch > - cleanup.linux-xen.patch > - cleanup.xen.patchThis looks really good. A minor comment; I see lots of "#if 0" blocks added to the linux-xen files. These need to be "#ifndef XEN" so that we can more easily manage these changes versus upstream linux. If nobody else has comments, I can fix those when it gets committed to the tree. thanks, Alex -- Alex Williamson HP Linux & Open Source Lab _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2006-Feb-28 04:15 UTC
[Xen-devel] Re: [Xen-ia64-devel] [Patch] [RESEND] cleanup warning in xen/ia64
Hi, We changed from "#if 0" to "#ifndef XEN" in "cleanup.linux-xen.patch", and updated "cleanup.xen.patch" to changeset:9000. We don''t resend "cleanup.include.xen.patch", because it was committed to xen-unstable tree. Signed-off-by: Tsunehisa Doi <doi.tsunehisa@jp.fujitsu.com> Signed-off-by: Kouya SHIMURA <kouya@jp.fujitsu.com> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com> Best regards, Kan, and Fujitsu team Alex Williamson wrote:>On Mon, 2006-02-27 at 10:48 +0900, Akio Takebe wrote: >> Hi, all >> >> We clean up warning in xen/ia64 . >> We have cleaned up many warnings, but it remainded some warnings yet. >> >> These patches fix many issue (ex. panic dom0, oops domU/dom0...). >> we will fix compile warnnings one step at a time. >> >> For xen (common) >> - cleanup.include.xen.patch >> >> For xen (ia64) >> - cleanup.include.asm-ia64.patch >> - cleanup.linux.patch >> - cleanup.linux-xen.patch >> - cleanup.xen.patch > > This looks really good. A minor comment; I see lots of "#if 0" blocks >added to the linux-xen files. These need to be "#ifndef XEN" so that we >can more easily manage these changes versus upstream linux. If nobody >else has comments, I can fix those when it gets committed to the tree. >thanks, > > Alex > >-- >Alex Williamson HP Linux & Open Source Lab > > >_______________________________________________ >Xen-ia64-devel mailing list >Xen-ia64-devel@lists.xensource.com >http://lists.xensource.com/xen-ia64-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alex Williamson
2006-Feb-28 18:34 UTC
[Xen-devel] Re: [Xen-ia64-devel] [Patch] [RESEND] cleanup warning in xen/ia64
On Tue, 2006-02-28 at 13:15 +0900, Masaki Kanno wrote:> Hi, > > We changed from "#if 0" to "#ifndef XEN" in "cleanup.linux-xen.patch", > and updated "cleanup.xen.patch" to changeset:9000. > We don''t resend "cleanup.include.xen.patch", because it was committed > to xen-unstable tree.Applied. -- Alex Williamson HP Linux & Open Source Lab _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel